On Fri, Jul 8, 2016 at 11:39 AM, Felipe G <fel...@gmail.com> wrote: > Is there a way to make the checkin-needed flag generate a template comment > (like the approval-* ones do) with something like this? (Or encourage > people to use the per-patch checkin? flag) > > """ > Has this patch been through try? [ Yes / No, I believe it's not necessary ] > Does this patch contain the correct author / commit message? [ Yes > (preferred) / No, but I'm providing it here: ] > Are there any other dependencies that should be landed together? [ Yes, ... > / No ] > """ > > Probably just asking if the information is present will reduce the number > of requests made without it >
My knee jerk reaction is we shouldn't bother: MozReview handles most of this "validation" and usage of MozReview has been steadily increasing. We're trending towards a world where the only patches on Splinter are for security-sensitive bugs (MozReview can't handle those yet) and the people submitting patches to security bugs tend to know what they're doing so I don't think these added checks will help. > > On Fri, Jul 8, 2016 at 10:47 AM, Ryan VanderMeulen <rya...@gmail.com> > wrote: > > > FWIW, there's also an MDN page that documents a lot of this as well: > > > > > https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F > > > > -Ryan > > > > > > On 7/8/2016 2:32 AM, Carsten Book wrote: > > > >> Hi, > >> > >> someone might not know that doing checkins for checkin-needed request is > >> not automated yet and completely a fully human task :) (no we Sheriffs > are > >> not bots ;) > >> > >> It would help us a lot if a checkin needed request would contain > complete > >> Author/Patch information like: > >> > >> > >> - Author (use the information from their Bugzilla account if needed) > >> with Name *and *Emailadress. > >> - Bug number > >> - Commit message (keeping in mind that the commit message should be a > >> brief description of what the patch is *doing*) > >> - Format should be something like "Bug 123456 - Add a null check > to > >> XYZ to avoid a crash. r=somebody" > >> > >> > >> And also if there is a specific sequence/dependency you want to checkin > >> the > >> patches it would help also a lot if you could make a short comment in > the > >> Bug like please checkin part x then patch y or like first bug 123 then > >> this > >> bug and then bug 8910. > >> > >> This would help us a lot :) > >> > >> Thanks! > >> > >> - Tomcat > >> > >> > > _______________________________________________ > > dev-platform mailing list > > dev-platform@lists.mozilla.org > > https://lists.mozilla.org/listinfo/dev-platform > > > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
