> On Apr 15, 2016, at 12:44 PM, Jim Blandy <jbla...@mozilla.com> wrote:
> 
> On Fri, Apr 15, 2016 at 12:36 PM, Jonas Sicking <jo...@sicking.cc> wrote:
> 
>> We could also make the default behavior be to cancel old pushes. And
>> then enable push message syntax for opting in to not cancelling.
>> 
>> 
> This could be very frustrating (and cause farm work to be wasted) if it
> happened accidentally.
> 
> Perhaps it would be less error-prone to require an explicit choice of
> overlapping or cancellation, and immediately reject pushes that haven't
> chosen one or the other, for bugs that already have running try pushes.

Explicit choice sounds good.  I'd rather it not be required before pushing if 
it were a prompt.  If it were a try syntax option I would likely set "do not 
cancel" as a default to prevent accidental cancellation.

My proposal: enhance mach try to surface this information and allow convenient 
cancellation.  And if it were pushed using some other manner like a web ui or 
hg push then the default behavior would remain as it is today (to prevent 
losing work by default).  So something like this:

   $ ./mach try args

   remote: adding changesets
   remote: adding manifests
   remote: adding file changes
   remote: added 2 changesets with 1 changes to 2 files (+1 heads)
   remote: recorded push in pushlog
   remote:
   remote: View your changes here:
   remote:   https://hg.mozilla.org/try/rev/REV1
   remote:   https://hg.mozilla.org/try/rev/REV2
   remote:
   remote: Follow the progress of your build on Treeherder:
   remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=REV2
   remote: recorded changegroup in replication log in 0.093s

   Please help make Try faster by canceling old jobs.  You have two existing 
builds for this bug:

     https://treeherder.mozilla.org/#/jobs?repo=try&revision=REV3 (50% complete)
     https://treeherder.mozilla.org/#/jobs?repo=try&revision=REV4 (90% complete)

   Would you like to cancel these jobs? (Y/N)

Brian

_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to