Hi, One major remaining Moz2Dification step is the conversion of thebes types such as gfxSize, gfxPoint, gfxRect, and gfxMatrix to their Moz2D equivalents. But this is largely blocked by the fact that the thebes types use double-precision FP values while the Moz2D types use single-precision FP values.
The difference in precision doesn't matter... except when it does. Here are four cases I've seen where a proposed change has been blocked by this issue: https://bugzilla.mozilla.org/show_bug.cgi?id=984278#c10 https://bugzilla.mozilla.org/show_bug.cgi?id=1224093#c2 https://bugzilla.mozilla.org/show_bug.cgi?id=1222325#c0 https://bugzilla.mozilla.org/show_bug.cgi?id=1216396#c5 It seems like the strategy so far has been to just make the changes, and then insert double-precision when it seems like it's necessary -- the existence gfx::RectDouble is evidence of this. But it's hard to know when it is necessary. Another possibility would be to just change the Moz2D types to use double-precision, which presumably would avoid problems like the above ones. But I suspect that will have some opposition, perhaps for performance reasons and perhaps because Moz2D's use of single-precision mirrors some of the graphics APIs that Moz2D interfaces with. I'd love to find a way to break the current impasse, because Moz2Dification will never be completed otherwise; it has certainly halted my efforts on that task. Thanks. Nick _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
