On 06/12/2014 23:42, Gijs Kruitbosch wrote: > (replying to m.d.platform, but also pulling some folks into the CC list) > > Hi Philip, > > Thanks for raising this. > > On 05/12/2014 23:13, Philip Chee wrote: >> I think the changes for this bug are sub-optimal. >> >> First: >> >> https://hg.mozilla.org/mozilla-central/rev/460d573b8822#l3.17 >> +<!ENTITY allowPagesToUseColors.automatic.label "Automatic"> >> +<!ENTITY allowPagesToUseColors.always.label "Always"> >> +<!ENTITY allowPagesToUseColors.never.label "Never"> >> >> It's never explained anywhere what "Automatic" does. I expect end users >> to start hitting support.mozilla.org on this when this goes to release. >> This can be mitigated by replacing "Automatic" with something more >> informative, understandable, clearer, and less beware of leopard. > > I'm happy to agree "Automatic" isn't ideal, but nobody came up with a > better suggestion. I don't think making it a full sentence will be any > better, and it's hard to succinctly summarize this otherwise. Do you > have a suggestion?
People using high contrast themes in windows would know what high contrast themes are since they have to select those themes from the "High Contrast Themes" section. > (fwiw, *I* have no idea what "beware of leopard" means) That illustrates my point exactly! As in replacing "Automatic" with "Beware of leopard" makes no difference to the (lack of) clarity. Also did you remember to pack a toothbrush and a towel before heading out to Portland? >> Also the use case for Bug 639134 was for Windows. Does this setting have >> the proper effect on Linux and OSX? > > We don't currently honour high contrast themes on either of those OSes. > OS X doesn't really have a high contrast theme like Windows/GTK does, > that I'm aware of (they have a high contrast mode that messes with the > display at the OS level, AIUI). Linux's API is basically "read the > current GTK theme name and if it says 'high contrast', it probably is", > which is presumably part of the reason support was never implemented. > That is actually on my list of things to get to, in which case this > option should Just Work. > > So for Linux/OSX the option "Automatic" devolves to "Always" while we > don't recognize high contrast themes. I don't think that that's bad > enough to justify doing a bunch of work to default to the "Always" > setting (and maybe hide the "Automatic" option, unless people have > manually set it to that by about:config or by copying a profile from > another machine, etc.) on those OSes, especially if we do still have > implementing high contrast support for Linux on the agenda, but we could > do that if people are convinced that's worth it. > > The Linux implementation is bug 239914 / bug 1064164. AFAICS nobody is working on GTK and OSX. In the mean time I propose that "Automatic" not be exposed to users on those platforms who might wonder what it does (answer: nothing). File under useless-UI Phil -- Philip Chee <phi...@aleytys.pc.my>, <philip.c...@gmail.com> http://flashblock.mozdev.org/ http://xsidebar.mozdev.org Guard us from the she-wolf and the wolf, and guard us from the thief, oh Night, and so be good for us to pass. _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
