I think the changes for this bug are sub-optimal. First:
https://hg.mozilla.org/mozilla-central/rev/460d573b8822#l3.17 +<!ENTITY allowPagesToUseColors.automatic.label "Automatic"> +<!ENTITY allowPagesToUseColors.always.label "Always"> +<!ENTITY allowPagesToUseColors.never.label "Never"> It's never explained anywhere what "Automatic" does. I expect end users to start hitting support.mozilla.org on this when this goes to release. This can be mitigated by replacing "Automatic" with something more informative, understandable, clearer, and less beware of leopard. My second problem is that the new preference is a tri-state (int) preference. The use of multi-state preferences has not always been a happy story. See For example: > Bug 1042135 - Change three-state DNT back to two state and update text. > Bug 530209 - Improve search suggestions ui for locationbar prefs I suggest that unless there is a clear win for a multi-state preference in this particular instance, we should stick to something simpler. For example two boolean preferences. The original preference: browser.display.use_document_colors plus a new one: browser.display.use_document_colors.even_for_high_contrast_os_themes.do_what_I_say_dammit Also the use case for Bug 639134 was for Windows. Does this setting have the proper effect on Linux and OSX? Is this even needed on non-windows? Phil -- Philip Chee <phi...@aleytys.pc.my>, <philip.c...@gmail.com> http://flashblock.mozdev.org/ http://xsidebar.mozdev.org Guard us from the she-wolf and the wolf, and guard us from the thief, oh Night, and so be good for us to pass. _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
