If we are talking about checking (a separate thing, in my opinion), then we 
should be talking about linting :)  Checking for formatting is probably less 
useful than something more concrete.  Having run jshint over some of the code, 
I was horrified at the output it produced.

That said, checking formatting in general is a massive waste of time.  If we 
had an automated tool, then I could notice a problem, then say "did you run 
{clang-format,astyle,js-beautify}", but generally not worry about formatting.

----- Original Message -----
From: "Till Schneidereit" <t...@tillschneidereit.net>
To: "Ehsan Akhgari" <ehsan.akhg...@gmail.com>
Cc: "Mike Hommey" <m...@glandium.org>, dev-platform@lists.mozilla.org, "Andrea 
Marchesini" <amarches...@mozilla.com>
Sent: Thursday, December 19, 2013 8:11:39 AM
Subject: Re: style guide proposal

[...]

I think we should increase the checking we do, and make it a habit to run
the checks before try-servering or putting a patch up for review. It's
really not a good investment of anyone's time to have to deal with trailing
whitespace during a review.

[1]:
http://mxr.mozilla.org/mozilla-central/source/js/src/config/check_spidermonkey_style.py
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to