On Thu, Dec 19, 2013 at 5:02 PM, Ehsan Akhgari <ehsan.akhg...@gmail.com>wrote:
> -- > Ehsan > <http://ehsanakhgari.org/> > > > On Thu, Dec 19, 2013 at 4:32 AM, Mike Hommey <m...@glandium.org> wrote: > > How about we just use clang-format? > > http://www.irill.org/videos/euro-llvm-2013/jasper-hires.webm > > > clang-format has a basic support for the Mozilla coding style, and we can > definitely extend it to add support for this heuristic. > FWIW, SpiderMonkey does some *very rudimentary* style checking as part of `make check`. Failing these checks causes oranges on tbpl. Mostly, njn implemented checking for correct header inclusion and ordering after his cleanup heroics. The exact set of checks being done is described in the header of the python script doing the checking[1]. I think we should increase the checking we do, and make it a habit to run the checks before try-servering or putting a patch up for review. It's really not a good investment of anyone's time to have to deal with trailing whitespace during a review. [1]: http://mxr.mozilla.org/mozilla-central/source/js/src/config/check_spidermonkey_style.py _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
