On 2013-11-20 12:37 PM, Benoit Jacob wrote:
Talking about ideas for further extending the impact of UNIFIED_SOURCES, it seems that the biggest limitation at the moment is that sources can't be unified between different moz.build's. Because of that, source directories that consist of many small sub-directories do not benefit much from UNIFIED_SOURCES at the moment. I would love to have the ability to declare in a moz.build that UNIFIED_SOURCES from here downwards, including subdirectories, are to be unified with each other. Does that sound reasonable?
I don't think that we should do this for now. One problem with unified builds is that adding or removing files can shift things into different translation units and cause build failures. Because of this reason, I don't like the idea of unifying multiple cpp files in multiple directories into the same translation unit. But further down the road, opting into this by moving things into one moz.build file may make sense. I have experimented with this once in bug 936899.
Cheers, Ehsan _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
