+1 for always using virtual (useful documentation without having to check the super class), even with MOZ_OVERRIDE (just style).
Also +1 for /* static */ on method definitions (when they are declared static) because that is useful information. /* virtual */ on definitions, I don't find useful because it is not necessary to understand the definition of the method, only when the method is called. On Wednesday, September 4, 2013 4:18:37 PM UTC+12, Robert O'Callahan wrote: > I like to put "virtual" on all methods that are virtual, even when it's not > > strictly necessary because the method overrides a virtual method of the > > parent class. > > > > Other people disagree, especially when the method has MOZ_OVERRIDE on it as > > well. > > > > What say you all? > > > > Rob > > -- > > Jtehsauts tshaei dS,o n" Wohfy Mdaon yhoaus eanuttehrotraiitny eovni > > le atrhtohu gthot sf oirng iyvoeu rs ihnesa.r"t sS?o Whhei csha iids teoa > > stiheer :p atroa lsyazye,d 'mYaonu,r "sGients uapr,e tfaokreg iyvoeunr, > > 'm aotr atnod sgaoy ,h o'mGee.t" uTph eann dt hwea lmka'n? gBoutt uIp > > waanndt wyeonut thoo mken.o w * > > * _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
