On 7/11/2013 9:23 AM, Justin Lebar wrote: > One thing I've been thinking about is /why/ people are slow at reviews. > > Someone who usually has a long review queue has told me that he "hates" > reviewing code. I realized that we don't really have a place at Mozilla for > experienced hackers who don't want to do reviews. Should we? Could we do > this > without violating people's sense of fairness? > > As another data point, someone told me recently that he's trying not to become > a peer of the modules he's working on, because he doesn't want to review code. > Maybe we're not incentivizing people enough to be reviewers. > > Roc said that we've spoken with people who are slow at reviews. Did we learn > anything from that? I'd expect that people are slow for different reasons. > > It seems backward to me to focus on a solution without first understanding the > causes. I can definitely sympathize with this, as the build system owner (now peer), and test harness owner I get a lot of reviews thrown my way. I have been able to pretty successfully grow the peer list of both modules over the past few years, and it's worked out pretty well. One nice benefit that people shouldn't overlook is that by becoming a peer in a module you work in you help spread out the review load, which means that the owner and other peers have more time to review *your* patches. This has been really great for me in the build system, where I prioritize reviews requests from the other peers, and in return also get quick turnaround on patches I need review for. It's a little "tit-for-tat", but I think it's a healthy positive feedback loop.
-Ted _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
