On 7/9/13 4:29 PM, Chris Peterson wrote:
I've seen people change their Bugzilla name to include a comment about
being on PTO.
Sure. As a simple example, I did that on June 20th. I got about 20
review requests over the course of the following week and a half, and
that's with most of the people who would normally ask me for review
_not_ doing so because they knew I was away.
Bugzilla's interdiff is totally unsuitable for this
purpose, unfortunately, because it fails so often.
Can we fix Bugzilla's interdiff?
Not easily, because it does not have access to the original code... The
most common failure mode here is something like this:
1) Author posts patch.
2) Review happens.
3) Author rebases patch to tip, makes edits to address review
comments, re-requests review.
At this point, bugzilla interdiff between the new patch and the old one
will only work if the rebase was exceedingly trivial. Further, what's
really desired in most cases is the diff between the rebased patch and
the patch that addresses comments, not the diff between the old patch
and the new patch.
-Boris
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
