On Thu, Apr 4, 2013 at 4:50 PM, Jeff Walden <jwalden+...@mit.edu> wrote: > On 04/04/2013 01:55 PM, Daniel Holbert wrote: >> MSVC C4244 is by far our spammiest MSVC warning -- it's already disabled >> in /js/src due to its low value::trouble ratio. > > Actually I think this is a mistake, one that we should fix at some point.
Bug 857863 says there are 1702 occurrences of this warning in Gecko (excluding SpiderMonkey). Warnings about possibly dubious but common practices aren't much use. I gave up on turning on -Wshadow for this reason, and it looks like C4244 has a higher false positive rate. It'll be an uphill battle at best. Nick _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
