(Ignoring whether or not WARNINGS_AS_ERRORS is a good idea, ignoring whether or not having it disabled by default on developer builds but enabled on automation is a good idea, ignoring whether or not we can deal with the tendency of gcc to lurch from complaining incessantly about one silly thing to complaining about another on version upgrades, ignoring the differences in warnings between different compilers ..)
The lack of platform parity for WARNINGS_AS_ERRORS being enabled at all makes developing on Windows a complete PITA. There are 50+ directories[0] that have WARNINGS_AS_ERRORS enabled for gcc/clang and not MSVC. So I come along and write a patch that builds just fine on my machine, and push it to inbound and every other platform is broken. Now I have to push pretty much every patch I write to try (or I just have to disable WARNINGS_AS_ERRORS in directories where problems occur). Either this parity issue needs to be fixed or we need to turn off WARNINGS_AS_ERRORS. - Kyle [0] http://hg.mozilla.org/mozilla-central/rev/4983b42d58c9 _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
