On Fri, Jan 18, 2013 at 1:50 PM, L. David Baron <dba...@dbaron.org> wrote:
> On Friday 2013-01-18 11:49 -0500, Ehsan Akhgari wrote: > > I see. I think your assumption in point #2 above is mistaken. We > > do not close trees because of the gravity of issues affecting the > > code base. We do close them when there are busted builds or failing > > tests because those prevent proper testing of changesets landed on > > top of them. Since your conclusion (and dbaron's) are based on this > > incorrect assumption, I don't agree that we should close the Beta > > tree at this point. > > But there's the question of what constitutes "proper testing". > We're still running all of our usual tests across our usual > platforms on every push (modulo coalescing). We're just not running > quite all of them for the additional testing we do on nightlies. > > I think the amount of additional test coverage we get from testing > nightlies is pretty small, since the differences between nightlies > and the PGO builds we generate for every-few-hours testing are > pretty small. I value that additional testing much less than I'd > value, say, running our tests on a localized build, or with > different system locale and timezone settings, or with common > extensions installed, or with other variations in commonly-changed > profile settings. > I absolutely share all of these concerns, but I don't think this is going to help us with the problem at hand... They're definitely worth looking into once we're past this. Cheers, -- Ehsan <http://ehsanakhgari.org/> _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform