On Fri, Jan 18, 2013 at 5:39 AM, L. David Baron <dba...@dbaron.org> wrote:

> So given that this is a regression in Firefox 19 (which is now on
> beta), and the only reason we're not seeing this permaorange on beta
> is because we don't generate non-debug nightly builds on beta (and I
> don't think we run tests on any of our debug nightlies), it seems
> odd to close only Aurora for this.  It seems like depending on what
> we think of its seriousness, we should either close both aurora and
> beta, or we should close neither.
>

I don't think we've ever closed a tree for test failures which _would_ show
up there if we ran tests there but don't because we don't do that...


> I'm inclined to say that this shouldn't hold the tree closed, though
> I also think Ehsan's workaround in the bug (to say that testpilot
> already customized the toolbar) is also perfectly reasonable; it
> just means we're testing a slightly different configuration.
>

I don't think that anybody has done enough debugging to understand exactly
why the failures happen so I'm extremely uncomfortable with reopening the
tree until such investigation has been done.


> (We have *horrible* diversity of testing configuration compared to
> what our users actually use; I don't think we should hold the tree
> closed over this miniscule piece of it; I also think we should try
> to improve it.)


I don't see why we should assume that this is a benign failure at this
point.

On related news, this thread diverged into multiple different private
threads, and it seems like the devtools team has two patches in bugs 824016
and 774619 which can probably help.  I have asked them to land both patches
as they don't require approval (since they're both test only changes.)
Hopefully those would help.

Cheers,
--
Ehsan
<http://ehsanakhgari.org/>
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to