On 14/11/12 19:27, Gavin Sharp wrote: > On Wed, Nov 14, 2012 at 10:53 AM, Mounir Lamouri <mou...@lamouri.fr> wrote: >> For that, we will need some tools to know if we are building for Release >> (and let say Beta) where the feature should be hidden by default, with >> opposition to Aurora, Nightly or custom builds where the feature should >> be enabled by default. > > We already have ways of doing that (usually based off of > MOZ_UPDATE_CHANNEL). We could introduce some more elegant/robust > solution - we already do it enough that a better solution would > probably be nice. See > https://bugzilla.mozilla.org/show_bug.cgi?id=803276#c4.
MOZ_UPDATE_CHANNEL contains a string and AFAIK, we can't use C preprocessor to compare strings so it might not be enough. >> Also, how would that work for things that doesn't have >> Nightly/Aurora/Beta/Release channels? > > What do you mean? I was thinking of things like Firefox OS that might not have such concept. We should make sure that they do not end up doing the wrong thing. -- Mounir _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
