On 2012-11-09 1:28 PM, Kyle Huey wrote:
I reviewed a patch today that had:

using namespace mozilla;
using namespace dom;

The intent is to pull in the contents of both the mozilla and mozilla::dom
namespaces, but this is only clear if you know that there is no top-level
dom namespace.  In the review comments I asked the author to write this
with fully qualified namespaces.  That is, as:

using namespace mozilla;
using namespace mozilla::dom;

The style guidelines recommend against using nested namespaces, so doing what you suggest would make them self-inconsistent.

Cheers,
Ehsan

_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to