On Fri, Nov 9, 2012 at 10:46 AM, Gregory Szorc <g...@mozilla.com> wrote:
> On 11/9/12 10:28 AM, Kyle Huey wrote: > >> I reviewed a patch today that had: >> >> using namespace mozilla; >> using namespace dom; >> >> The intent is to pull in the contents of both the mozilla and mozilla::dom >> namespaces, but this is only clear if you know that there is no top-level >> dom namespace. In the review comments I asked the author to write this >> with fully qualified namespaces. That is, as: >> >> using namespace mozilla; >> using namespace mozilla::dom; >> >> If nobody has objections I'd like to add this to the style guide. >> > > Why stop there? What about: > > > using namespace ::mozilla; > using namespace ::mozilla::dom; > > In the past people have complained when I've written code that prefixes symbols with '::'. I suspect my proposal will be easier to reach consensus on. ;-) I don't have any objections to :: though. - Kyle _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
