On Monday 2012-10-08 20:03 +1100, Nicholas Nethercote wrote: > In https://wiki.mozilla.org/Tree_Rules/Inbound, one of the steps under > "Please do the following after pushing to inbound" is: > > "Add the inbound changeset URL to the bug. If there are multiple > patches on the bug and you are not pushing all of them, please > indicate which one(s) you pushed (eg: use patch -> details -> comment > on patch, or else use the new per-patch checkin+ flags)." > > I heard someone say today that this should be an optional step. I > think the rationale is that it's unnecessary because the subsequent > mozilla-central links usually contain much the same information. I am > wondering if others agreed or disagreed with this opinion.
What the subsequent links don't contain is the fact that the landing on mozilla-central was done as part of a mozilla-inbound merge. This makes it look like the person who merged mozilla-inbound was actually responsible for the landing. Given that those links are, I think, added using an automated tool, it might be possible to add that information. I think such a change in policy would be reasonable if the mozilla-inbound merge notations in bugs said explicitly that the push was a merge from inbound. (I think that would be a great addition to the m-cmerge tool if my understanding that that's part of what the m-cmerge tool does is correct.) On the other hand, if that's not something that's done by the tool, I wouldn't be in favor of imposing more on the people who do mozilla-inbound merges. -David -- 𝄞 L. David Baron http://dbaron.org/ 𝄂 𝄢 Mozilla http://www.mozilla.org/ 𝄂 _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
