On 09/21/2012 11:50 PM, Ehsan Akhgari wrote: > On 12-09-20 8:22 PM, Ehsan Akhgari wrote: >> Aryeh has been doing a heroic job (I mean, heroic, for reals!) in bug >> 777292 to make nsresult a C++ enum, as opposed to just an unsigned int. >> I've stepped in to help for the last few bits, and I'm planning to >> land this work as soon as the (hopefully) final patch that I put up for >> review gets an r+. This should generally not affect you, except that it >> makes the code better, but please keep an eye on any possible >> regressions, especially if you see negative nsresult values anywhere on >> Windows when this lands. > > I landed this on mozilla-central and mozilla-inbound a few hours ago, > and it seems to have stuck! If you're maintaining a project branch, > please make sure to merge m-c into your branch and test to make sure > your code is not doing anything bad with nsresults. If you see > problems, please ping me on IRC.
Awesome! This already caught a stupid mistake I was writing (NS_ENSURE_SUCCESS instead of NS_ENSURE_TRUE). Kudos to both of you guys! -- Mounir _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
