On Fri, Sep 21, 2012 at 3:18 PM, David Rajchenbach-Teller <dtel...@mozilla.com> wrote: > That sounds great! > Are you somehow using the new C++11 typesafe enums?
That's phase II, tracked by bug 779473. With any luck, it should follow close behind. In case anyone's wondering about the utility of the change: since I got a mostly-working patchset together less than two months ago, a few real bugs were introduced that I caught. A patch introduces a new nsresult misuse maybe once every two weeks. Things that cropped up since I wrote my patchset: * Bug 779122: returned boolean instead of nsresult, introduced July 24 * Bug 779123: returned false (= NS_OK) when NS_ERROR_FAILURE was intended, introduced July 24 * Bug 782232: returned false (= NS_OK) when NS_ERROR_FAILURE was intended, introduced August 7 * Bug 783863: NS_FAILED check that did nothing because it was really checking a small integer, introduced August 18 * Bug 788645: returned false (= NS_OK) when NS_ERROR_FAILURE was intended, introduced August 30 Plus of course I found and fixed a slew of preexisting bugs. The large majority of these didn't cause user-facing problems, but they generally obscured what the code actually did. All these would now be compile errors. _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
