On 08/08/2012 04:32 PM, Justin Lebar wrote:
So I have this scripts that gives for each header the number of translation
units that use it, here is part of the output (i skipped the headers
included in less than 9 TUs) from a week ago (after dzbarsky's patch):
http://pastebin.mozilla.org/1745141
It is an approximation because it uses data generated by make for a given
build configuration, but it gives a good idea of some of the headers that
are included way too much.
But your contention is that fixing this will reduce build times, right?
Did you observe a change in build times with dzbarsky's patch, or any
of the other work that you have done? Or is the improvement in build
times completely speculative at this point?
I agree with Benjamin that our efforts may be better targeted at PCH,
if headers are really a bottleneck.
Yes, I noticed that building after touching Layers.h is faster after
dzbarsky's patch.
I think we just need to be a bit more careful about include dependencies
when adding new code (this is really not hard nor time-consuming) and
maybe fix one or two of the existing bottlenecks.
I agree that fixing everything would be a waste of time.
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
