For me its primarily a headspace and workflow interruption reason. I also don't have an up to date comm checkout on this laptop, *and* I sent that from my mobile device rather than my laptop to boot.
With young children at home and a sick mother of them, plus the headspace required to triage/drive Firefox Release issues it adds up into sometimes I can only review/stamp an easy patch rather than even offer advice on how to fix or do it myself. If I didn't review/stamp this could have languished a *lot* longer until I could have done the patch myself or someone else was able to review... ~Justin Wood (Callek) On Wed, Aug 10, 2016 at 8:03 AM, ISHIKAWA, Chiaki <ishik...@yk.rim.or.jp> wrote: > On 2016/08/10 5:26, Justin Wood wrote: >> >> As a comm-central build peer, I'll rs+ (rubber-stamp+) a change to the >> hgignore to ignore "mozilla" instead of "^mozilla$" for whoever wants >> to land it, to bandaid this issue. >> >> ~Justin Wood (Callek) > > > I filed > Bug 1293993 - A bandaid fix: Very bad slowness with fsmonitor extension when > I use |hg| in local comm-central repository > and a patch there. > > A philosophical mumbling: > BTW, I am still perplexed why someone with an authority to review and > rubber-stamp a patch creates a simple patch like this and does it on their > own quickly in mozilla community. > > In contrast to the mozilla practice, back in the old days of GNU Project, > Stallman himself fixed a problem when he learned of an issue and half-baked > patch submitted, and simply created a better patch and the case would be > closed. I personally saw this happen a few times: Stallman created better > patches, better than the patches I created, and closed the bugs which I > noticed and for which I produced local patches. Sure this may not scale > well, but for a hot fix that bothers people in major way and need to fix > quicly, etc., this old practice is much better. I think it is just a > difference of the culture, but still I find it a little perplexing. > > > > >> >> On Tue, Aug 9, 2016 at 4:20 PM, Andrew Halberstadt >> <ahalberst...@mozilla.com> wrote: >>> >>> On 09/08/16 12:34 PM, ISHIKAWA,chiaki wrote: >>>> >>>> >>>> On 2016/08/09 1:57, Gregory Szorc wrote: >>>>> >>>>> >>>>> >>>>> Consider reporting an upstream issue. Instructions at >>>>> >>>>> >>>>> https://mozilla-version-control-tools.readthedocs.io/en/latest/hgmozilla/issues.html >>>>> >>>> >>>> I filed >>>> Bug 1293688 - Very bad slowness with fsmonitor extension when I use |hg| >>>> in local comm-central repository >>> >>> >>> >>> I think gps meant to file a bug in the core mercurial bug tracker: >>> https://bz.mercurial-scm.org/ >>> >>> >>> >>>> >>>> in bugzilla. >>>> >>>> There you can see that single call to fsmonitor extension took more than >>>> 25 seconds !? >>>> >>>> TIA >>>> >>> >>> _______________________________________________ >>> dev-builds mailing list >>> dev-builds@lists.mozilla.org >>> https://lists.mozilla.org/listinfo/dev-builds > > > _______________________________________________ > dev-builds mailing list > dev-builds@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-builds _______________________________________________ dev-builds mailing list dev-builds@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-builds
