This seems reasonable (although ideally the test plan would include some sort of graphical demonstration of what the outcome is expected to be, so we can confirm that it's laid out as expected).
The only thing I'm concerned about is, as Seb mentioned, that this adds a translatable string; we should also check that it shows up in the places that translators are looking so that it can *be* translated for the next point release. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/2102343 Title: [SRU] power: Add increase power consuption description for automatic suspend Status in gnome-control-center: Fix Released Status in OEM Priority Project: In Progress Status in gnome-control-center package in Ubuntu: Fix Committed Status in gnome-control-center source package in Noble: New Status in gnome-control-center source package in Oracular: New Status in gnome-control-center source package in Plucky: Fix Committed Bug description: [Impact] There is an EU directive, ErP Lot 6((EU) 2023/826) : https://eur- lex.europa.eu/eli/reg/2023/826/oj/eng It needs add a warning when disabling power management in Gnome settings such that there's a note on the power buttons that 'disabling sleep will increase energy consumption' https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/3353 https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/3082 https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/3408 https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/3113 [Test Plan] * Find a machine with 24.04 * Check if there is a warning when disabling power management. [Where problems could occur] * This patch is picked from upstream, the patch add a warning label, it's low risk. To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-control-center/+bug/2102343/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp