Comment on attachment 9099938 Bug 1586216: Fallback to a synchronous channel load if the url preloader cannot load the ftl file. r=kmag
### Beta/Release Uplift Approval Request * **User impact if declined**: Users with langpacks will see parts of the UI not translated into their preferred locale. * **Is this code covered by automated tests?**: Yes * **Has the fix been verified in Nightly?**: No * **Needs manual test from QE?**: Yes * **If yes, steps to reproduce**: We're unlikely to see langpack users in nightly so worth a manual pass. See https://bugzilla.mozilla.org/show_bug.cgi?id=1586216#c0 * **List of other uplifts needed**: None * **Risk to taking this patch**: Low * **Why is the change risky/not risky? (and alternatives if risky)**: Adds a fallback loading mechanism, worst case that fails too and we are still in the same situation but manual tests show that it works. * **String changes made/needed**: None -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1846371 Title: firefox 70.0 beta 11 isn't fully translated Status in Mozilla Firefox: Fix Released Status in firefox package in Ubuntu: Triaged Bug description: (this was initially spotted by ricotz) I'm running firefox 70.0~b11+build1-0ubuntu0.19.10.1 from ppa:mozillateam/firefox-next with a French locale, and the UI is not fully translated to French. The chrome (menu items and address bar help text) as well as other parts of the UI (new tab page) are correctly translated, but other parts aren't, such as the about:preferences settings page. Other about: pages (such as about:mozilla or about:robots) are correctly translated. about:addons is partially translated. Fully translated: - menu items - address bar - about:mozilla - about:robots - about:compat - about:welcome - about:newtab - about:webrtc Partially translated: - about:addons Not translated: - about:preferences - about:cache - "new extensions won't work in private mode" popover - "what's new" popover - about firefox dialog ProblemType: Bug DistroRelease: Ubuntu 19.10 Package: firefox 70.0~b11+build1-0ubuntu0.19.10.1 [origin: LP-PPA-mozillateam-firefox-next] ProcVersionSignature: Ubuntu 5.3.0-13.14-generic 5.3.0 Uname: Linux 5.3.0-13-generic x86_64 ApportVersion: 2.20.11-0ubuntu7 Architecture: amd64 BuildID: 20190930191143 CurrentDesktop: ubuntu:GNOME Date: Wed Oct 2 18:27:45 2019 DefaultProfileExtensions: extensions.sqlite corrupt or missing DefaultProfileIncompatibleExtensions: Unavailable (corrupt or non-existant compatibility.ini or extensions.sqlite) DefaultProfileLocales: extensions.sqlite corrupt or missing DefaultProfilePrefErrors: Unexpected character ',' before close parenthesis @ /usr/lib/firefox/omni.ja:greprefs.js:930 DefaultProfilePrefSources: /usr/lib/firefox/defaults/pref/vendor-gre.js /usr/lib/firefox/defaults/pref/channel-prefs.js DefaultProfilePrefs: network.manage-offline-status: true (/usr/lib/firefox/defaults/pref/vendor-gre.js) DefaultProfileThemes: extensions.sqlite corrupt or missing InstallationDate: Installed on 2018-08-21 (407 days ago) InstallationMedia: Ubuntu 18.10 "Cosmic Cuttlefish" - Alpha amd64 (20180821) Profiles: Profile1 (Default) - LastVersion=None/None (Out of date) Profile0 - LastVersion=70.0/20190930191143 (In use) SourcePackage: firefox UpgradeStatus: Upgraded to eoan on 2019-06-05 (119 days ago) To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1846371/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
