So the main problem here is that as things stand synchronously loading
ftl files from langpacks fail. Synchronous loads use
[`Cu.readUTF8URI`](https://searchfox.org/mozilla-
central/rev/05a22d864814cb1e4352faa4004e1f975c7d2eb9/intl/l10n/L10nRegistry.jsm#754)
which underneath uses the `URLPreloader` which [only supports file or
omnijar urls](https://searchfox.org/mozilla-
central/rev/05a22d864814cb1e4352faa4004e1f975c7d2eb9/js/xpconnect/loader/URLPreloader.cpp#565).
So attempting to load strings for browser.xhtml which uses synchronous
localization fails for the langpack and so falls back to the built-in
localization (yay for fallback!).

Unfortunately we cache these load failures which effectively poison the
langpack for future localization passes. In particular we cache the fact
that `branding/brand.ftl` isn't available in the langpack and then any
attempt to generate bundles that include `branding/brand.ftl` as a
resource (which the majority of pages do) fail because that file is
cached as missing. That seems like a different bug, I had the impression
that fluent would fall back on a per-resource level, not ignore the
entire locale if just one resource is missing, but we don't need to
solve that to fix this.

There are a couple of ways to solve this. Probably the ideal solution
would be to make the `URLPreloader` support loading out of langpacks.
But for a safer patch for beta I've just made `loadSync` fallback to an
alternative method of loading the ftl file in the event that
`Cu.readUTF8URI` fails.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1846371

Title:
  firefox 70.0 beta 11 isn't fully translated

Status in Mozilla Firefox:
  Confirmed
Status in firefox package in Ubuntu:
  Triaged

Bug description:
  (this was initially spotted by ricotz)

  I'm running firefox 70.0~b11+build1-0ubuntu0.19.10.1 from
  ppa:mozillateam/firefox-next with a French locale, and the UI is not
  fully translated to French. The chrome (menu items and address bar
  help text) as well as other parts of the UI (new tab page) are
  correctly translated, but other parts aren't, such as the
  about:preferences settings page. Other about: pages (such as
  about:mozilla or about:robots) are correctly translated. about:addons
  is partially translated.

  Fully translated:
   - menu items
   - address bar
   - about:mozilla
   - about:robots
   - about:compat
   - about:welcome
   - about:newtab
   - about:webrtc

  Partially translated:
   - about:addons

  Not translated:
   - about:preferences
   - about:cache
   - "new extensions won't work in private mode" popover
   - "what's new" popover
   - about firefox dialog

  ProblemType: Bug
  DistroRelease: Ubuntu 19.10
  Package: firefox 70.0~b11+build1-0ubuntu0.19.10.1 [origin: 
LP-PPA-mozillateam-firefox-next]
  ProcVersionSignature: Ubuntu 5.3.0-13.14-generic 5.3.0
  Uname: Linux 5.3.0-13-generic x86_64
  ApportVersion: 2.20.11-0ubuntu7
  Architecture: amd64
  BuildID: 20190930191143
  CurrentDesktop: ubuntu:GNOME
  Date: Wed Oct  2 18:27:45 2019
  DefaultProfileExtensions: extensions.sqlite corrupt or missing
  DefaultProfileIncompatibleExtensions: Unavailable (corrupt or non-existant 
compatibility.ini or extensions.sqlite)
  DefaultProfileLocales: extensions.sqlite corrupt or missing
  DefaultProfilePrefErrors: Unexpected character ',' before close parenthesis @ 
/usr/lib/firefox/omni.ja:greprefs.js:930
  DefaultProfilePrefSources:
   /usr/lib/firefox/defaults/pref/vendor-gre.js
   /usr/lib/firefox/defaults/pref/channel-prefs.js
  DefaultProfilePrefs: network.manage-offline-status: true 
(/usr/lib/firefox/defaults/pref/vendor-gre.js)
  DefaultProfileThemes: extensions.sqlite corrupt or missing
  InstallationDate: Installed on 2018-08-21 (407 days ago)
  InstallationMedia: Ubuntu 18.10 "Cosmic Cuttlefish" - Alpha amd64 (20180821)
  Profiles:
   Profile1 (Default) - LastVersion=None/None (Out of date)
   Profile0 - LastVersion=70.0/20190930191143 (In use)
  SourcePackage: firefox
  UpgradeStatus: Upgraded to eoan on 2019-06-05 (119 days ago)

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/1846371/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to