On Tue, Sep 06, 2011 at 03:05:11AM +0200, Jon Lachmann wrote: > After a long vacation etc. i managed to create a package named > hunspell-sv! > It is uploaded at http://mentors.debian.net/package/hunspell-sv > if you would have time to look into it. > > I have tested it and it works, it also appears to be lintian clean. > Please let me know if i have done anything wrong with it.
Hi, Jon, Your package looks mostly OK. However, I noticed some problems. So, I am attaching a patch swith some proposed changes. A summary of the reasons for them follows, * You are maintainer, so is not a Non-maintainer upload. Removed that line and changed versioning to a normal one. * You use installdeb-myspell, so you need to build-depend on dictionaries-common-dev (>= 1.10.5) (version is just to make sure no ancient openffice .org debhelper snippets are installed). * Do not install links in ancient usr/share/myspell/dicts location. * Updated debian/compat to 8 (You Build-Depend on debhelper >8) * You use installdeb-myspell --srcdir to install files, so you do not need neither installation dirs nor files for that stuff. * We do not ship mozilla*, just iceape-browser | iceweasel | icedove Besides that, if README is the same file as README_sv_SE.txt, I'd just install the last one. Also if NEWS is a file added by you, I'd put it under debian dir, so upstream dir is changed only if really needed. I'd also consider using debian/format 3.0 (quilt). Hope this helps, -- Agustin
diff -u hunspell-sv-1.46/debian/changelog hunspell-sv-1.46/debian/changelog --- hunspell-sv-1.46/debian/changelog +++ hunspell-sv-1.46/debian/changelog @@ -1,6 +1,5 @@ -hunspell-sv (1.46-1.1) unstable; urgency=low +hunspell-sv (1.46-1) unstable; urgency=low - * Non-maintainer upload * Initial release with dictionaries from www.dsso.se -- Jon Lachmann (JoTaB) <j...@lachmann.nu> Mon, 30 May 2011 16:03:00 +0100 diff -u hunspell-sv-1.46/debian/control hunspell-sv-1.46/debian/control --- hunspell-sv-1.46/debian/control +++ hunspell-sv-1.46/debian/control @@ -2,14 +2,14 @@ Section: text Priority: optional Maintainer: Jon Lachmann <j...@lachmann.nu> -Build-Depends: debhelper (>= 8) +Build-Depends: debhelper (>= 8), dictionaries-common-dev (>= 1.10.5) Standards-Version: 3.9.2 Homepage: http://dsso.se Package: hunspell-sv-se Architecture: all Depends: dictionaries-common (>= 0.10), ${misc:Depends} -Suggests: libreoffice, mozilla, mozilla-thunderbird +Suggests: libreoffice, iceape-browser | iceweasel | icedove Conflicts: openoffice.org (<= 1.0.3-2), myspell-sv-se Replaces: myspell-sv-se Provides: hunspell-dictionary, hunspell-dictionary-sv, myspell-sv-se diff -u hunspell-sv-1.46/debian/links hunspell-sv-1.46/debian/links --- hunspell-sv-1.46/debian/links +++ hunspell-sv-1.46/debian/links @@ -3,5 +2,0 @@ -usr/share/hunspell/sv_SE.aff usr/share/myspell/dicts/sv.aff -usr/share/hunspell/sv_SE.dic usr/share/myspell/dicts/sv.dic -usr/share/hunspell/sv_SE.aff usr/share/myspell/dicts/sv_SE.aff -usr/share/hunspell/sv_SE.dic usr/share/myspell/dicts/sv_SE.dic - diff -u hunspell-sv-1.46/debian/compat hunspell-sv-1.46/debian/compat --- hunspell-sv-1.46/debian/compat +++ hunspell-sv-1.46/debian/compat @@ -1 +1 @@ -5 +8 reverted: --- hunspell-sv-1.46/debian/install +++ hunspell-sv-1.46.orig/debian/install @@ -1,2 +0,0 @@ -sv_SE.dic usr/share/hunspell -sv_SE.aff usr/share/hunspell reverted: --- hunspell-sv-1.46/debian/dirs +++ hunspell-sv-1.46.orig/debian/dirs @@ -1,2 +0,0 @@ -usr/share/myspell/dicts -usr/share/hunspell
