Xiyue Deng <manp...@gmail.com> writes: > David Bremner <da...@tethera.net> writes: > >> Xiyue Deng <manp...@gmail.com> writes: >> >>> >>> Friendly ping. Should we merge and prepare for release (AIUI the >>> current proposed fix has reached consensus)? >>> >> >> In order to do request a freeze exception, we need version that has the >> minimal set of changes to fix the RC bug; it seems the git regex bug is >> not RC? Personally I'd make another branch off of 2.1.9 and work there. >> > > Given that 2.1.10 has not happened yet, maybe we can revert the regex > fix for 2.1.9 and wait until after Trixie to revert the revert? Let me > know. > >> I wasn't able to satisfactorially test this fix so far in trixie; I >> guess I should setup a bookworm container/VM. I tried manually replacing >> the directories in /usr/share/emacs/site-lisp/elpa/doom-themes with >> symlinks, but the various ways I tried simulating the upgrade always >> ended up removing the entire /usr/share/emacs/site-lisp/elpa/doom-themes >> (via removing the package). That can be verified with "ls -id" before >> and after. Can you give me a recipe? >> >> d > > A Bookworm container/VM would be easiest for reproducing the issue, as > it needs the symlink behavior from dh-elpa/2.0.16. A minimum > reproducing recipe would be (in a Bookworm container or VM): > > ,---- > | apt install -y --no-install-recommends elpa-doom-themes emacs-nox > | sed -i 's/bookworm/trixie/' /etc/apt/sources.list.d/debian.sources > | apt update > | apt upgrade -y --without-new-pkgs > `---- > > The error would look like: > > ,---- > | ... > | Setting up elpa-doom-themes (2.3.0-3) ... > | Install emacsen-common for emacs > | emacsen-common: Handling install of emacsen flavor emacs > | Install elpa-doom-themes for emacs > | install/doom-themes-2.3.0: Handling install of emacsen flavor emacs > | install/doom-themes-2.3.0: byte-compiling for emacs > | cp: cannot overwrite non-directory './extensions' with directory > '/usr/share/emacs/site-lisp/elpa-src/doom-themes-2.3.0/extensions' > | cp: cannot overwrite non-directory './themes' with directory > '/usr/share/emacs/site-lisp/elpa-src/doom-themes-2.3.0/themes' > | ERROR: install script from elpa-doom-themes package failed > | dpkg: error processing package elpa-doom-themes (--configure): > | installed elpa-doom-themes package post-installation script subprocess > returned error exit status 2 > | ... > `---- > > [...]
Actually, I just realized that this behavior could only happen with emacsen-common <= 3.0.7. With the latest fix in emacsen-common 3.0.8, when upgrading, emacsen-common will remove all flavor on unpacking, hence wiping compiled directories for each addon. This new behavior (fix for Bug#1106291) indirectly fixes this bug as well. So technically this fix is not strictly needed in dh-elpa-helper. Still I would like to have this fix installed so that we cover every potential problematic case. IIUC, this is still an issue for bookworm-backports. -- Regards, Xiyue Deng
signature.asc
Description: PGP signature
