Hello, On Sun 27 Apr 2025 at 03:25am -07, Xiyue Deng wrote:
> Interestingly, I cannot reproduce this with "apt dist-upgrade" which is
> why I didn't notice this issue earlier. On inspecting the install log,
> it looks like with "dist-upgrade", it will upgrade the emacs
> installation before addons which will first uninstall all addons and
> re-install them after emacs is configured, and hence worked around this
> potential issue.
>
> Still, I think it's better to have this fixed so that it works in all
> cases. I have tested a fix in the "bug#1104178" branch to be working.
> The diff can be seen here[1]. Please review.
It's an RC bug regardless; we always support partial upgrades, and
therefore can't rely on package upgrade order like that.
Given the freeze and dh-elpa's status as a toolchain package, we need to
handle this very carefully.
I think we need David's review on the basic approach taken by the patch
before proceeding much further, but I can comment on the shell
scripting:
- TIL unlink(1). Let's just use rm(1).
- Quote the output of readlink, i.e. "$(readlink "${SYMLINK}")".
Quotation resets inside $().
- "for file in ./*" not "for file in *"
per https://dwheeler.com/essays/filenames-in-shell.html sec. 1.2
--
Sean Whitton
signature.asc
Description: PGP signature
