Control: reassign -1 dh-elpa
Control: severity -1 grave
Justification: makes the package in question unusable by most or all users

Hi itd,

itd <i...@net.in.tum.de> writes:

> Package: elpa-doom-themes
> Version: 2.3.0-3
> Severity: normal
>
> Dear Maintainer,
>
> I've tried to upgrade from bookworm to trixie [0] with:
>
> | apt upgrade --without-new-pkgs
>
> This command failed, producing (among others) the following output:
>
> | Install emacsen-common for emacs^M
> | emacsen-common: Handling install of emacsen flavor emacs^M
> | Install elpa-doom-themes for emacs^M
> | install/doom-themes-2.3.0: Handling install of emacsen flavor emacs^M
> | install/doom-themes-2.3.0: byte-compiling for emacs^M
> | cp: cannot overwrite non-directory './extensions' with directory 
> '/usr/share/emacs/site-lisp/elpa-src/doom-themes-2.3.0/extensions'^M
> | cp: cannot overwrite non-directory './themes' with directory 
> '/usr/share/emacs/site-lisp/elpa-src/doom-themes-2.3.0/themes'^M
> | ERROR: install script from elpa-doom-themes package failed^M
> | ^[[1mdpkg:^[[0m error processing package elpa-doom-themes (--configure):^M
> |  installed elpa-doom-themes package post-installation script subprocess 
> returned error exit status 2^M
>
> (To proceed with the upgrade, I've appended `elpa-doom-themes-` to the
> failed command to remove the package for the time being.  With this
> added, the minimal system upgrade succeeded.)
>
> [0]: 
> https://www.debian.org/releases/trixie/release-notes/upgrading.en.html#minimal-system-upgrade
>
> Regards
> itd
>

Thanks for the report!  I believe this is an issue in dh-elpa since
2.1.2 when I changed the directory handling from creating a direct
symlink on top level to recursively symlink all files in directories
recursively (basically "cp -rsf") so that it recursively byte-compiles
all .el files.  Therefore if a package installs a directory under
".../elpa-src" it may cause this issue.  I used a bookworm docker image
and can reproduce this issue with elpa-doom-themes using "apt upgrade
--without-new-pkgs".  As this issue may cause packages fail to upgrade,
I'm upgrading the severity to grave.

Interestingly, I cannot reproduce this with "apt dist-upgrade" which is
why I didn't notice this issue earlier.  On inspecting the install log,
it looks like with "dist-upgrade", it will upgrade the emacs
installation before addons which will first uninstall all addons and
re-install them after emacs is configured, and hence worked around this
potential issue.

Still, I think it's better to have this fixed so that it works in all
cases.  I have tested a fix in the "bug#1104178" branch to be working.
The diff can be seen here[1].  Please review.

[1] 
https://salsa.debian.org/emacsen-team/dh-elpa/-/compare/master...bug%231104178?from_project_id=18920

-- 
Regards,
Xiyue Deng

Attachment: signature.asc
Description: PGP signature

Reply via email to