On 2025-08-16 22:43:53 -0400 (-0400), Theodore Ts'o wrote:
On Sat, Aug 16, 2025 at 05:53:46PM +0000, Jeremy Stanley wrote:I just want to chime in and say that a significant portion of my workday too is spent doing code review. I do find it relevant and useful, however I expect if you asked my employer they would not refer to my time as inexpensive... at least I certainly hope they don't see me that way. Code review done right takes significant time, and I'm not even sure I'm doing it entirely "right" in many cases, but I also prefer not to see the effort I invest devalued as "not expensive."
[...]
Code reivew at a company is very different from code review for some open source project on a forge.
[...]
Sorry, I should have been more clear that in this case my "employer" is a nonprofit foundation funding my work in several upstream open source communities using public forges, so the code I'm reviewing is submissions from random people on the Internet with anywhere between clueless and expert level experience in the project or with software development in general. The amount of effort needed to do thorough code review doesn't necessarily depend on whether you're being paid, but the incentive for thoroughness very well may.
I still assert that code review is not necessarily as inexpensive as was previously suggested in this thread (which I think you were agreeing with, even if your point was somewhat in a different direction). It often requires significant personal investment of time.
-- Jeremy Stanley
signature.asc
Description: PGP signature
