On Sunday, December 29, 2024 12:39:59 PM MST Richard Lewis wrote: > Otto Kekäläinen <o...@debian.org> writes: > >> >> i think the barrier is likely to be "i didnt know you could do that?" > >> >> rather than "how do i use that?" > >> > > >> > Salsa CI is and has always been opt-in. > >> > >> oops - i meant the oppposite, ie make people have to opt out of having > >> it run, rather than have to enable it > > > > A human needs to verify that the pipeline passes when it is activated, > > fix disable it or fix things if the CI isn't green. It does not make > > sense to activate it unattended, as it would risk causing a lot of > > failing pipelines and useless noise and a culture where people loose > > respect for "pipeline greenness". > > I dont really understand this point -- is it based on some empirical evidence? > > my opinion is that > - other than the first "enabling", every pipeline runs unattended > - people are not going to gain any "respect" for "pipeline greenness" by > hiding the pipeline - commits that fail the pipeline are still bad if the > pipeline didnt run, so why hide that information? - if you want people to > "respect the pipeline" you want more noise on such bad commits, not less?
My concern about auto-enabling it is that there are a number of projects for which the current default timeouts will always fail. I recently packaged pyinstaller. https://salsa.debian.org/python-team/packages/pyinstaller The default Salsa CI runners have a 3 hour timeout and the default salsa- ci.yml has a 2.75 hour timeout. For pyinstaller, these are insufficient. I ended up registering my own runner and editing the salsa-ci.yml to increase the timeouts. Note that my runner hardware is much quicker than the default Salsa CI runners, but even with that I needed to increase the timeouts. I don’t know how many packages would have this problem, but at the minimum the ones I am familiar with would include: qtwebengine-opensource-src qt6-webengine chromium I would recommend that if we want to enable Salsa CI by default we need to increase the timeouts to be able to handle large packages. -- Soren Stoutner so...@debian.org
signature.asc
Description: This is a digitally signed message part.
