On Sun, 14 Jul 2024 at 21:26, Philip Hands <p...@hands.com> wrote:
>
> Luca Boccassi <bl...@debian.org> writes:
>
> > Here's some stats from 'git shortlog --after="2021-12-31" -sn --all'.
> > In the last ~2.5 years, in netplan.io's github repo, there are only 2
> > contributors with more than 100 commits, and 2 with more than 10, and
> > 2 of them are Canonical employees:
> >
> > 569 Lukas Märdian
> > 310 Danilo Egea Gondolfo
> > 39 Simon Chopin
> > 38 Danilo Egêa Gondolfo
> > 11 Robert Krátký
> >
> > Same stat, for the same period, for systemd:
>
> If you're going to make such a comparison, wouldn't it make sense to
> limit it to the bits that might have some sort of relation to networkd?
>
> I suspect this is a bit nearer to a fair comparison:
>
> git shortlog --after="2021-12-31" -sn --all src/network/ network/
> 771 Yu Watanabe
> 107 Luca Boccassi
> 86 Zbigniew Jędrzejewski-Szmek
> 42 Lennart Poettering
> 32 Mike Yuan
> 24 Susant Sahani
> 18 Frantisek Sumsal
> 16 Daan De Meyer
> 13 Ronan Pigott
> 10 Jan Janssen
> 10 Michael Biebl
>
> which looks like its in the same ballpark, and presumably still includes
> quite a lot of stuff that would fall outside netplan's scope, so one
> could perhaps argue should be whittled down further.
Not at all: the way we structure systemd's repository, most of the
code that ends up in the network (or any other) binary are actually in
the shared areas. So if you really wanted to catch only the code that
ends up in the specific binaries:
$ git shortlog --after="2021-12-31" -sn --all src/network/ network/
src/libsystemd/ src/basic/ src/shared/ src/fundamental/
2858 Yu Watanabe
2195 Lennart Poettering
882 Zbigniew Jędrzejewski-Szmek
772 Luca Boccassi
724 Daan De Meyer
409 Mike Yuan
196 Frantisek Sumsal
128 Dan Streetman
87 David Tardon
76 Jan Janssen
64 Franck Bui
36 Nick Rosbrook
34 Cristian Rodríguez
31 Dmitry V. Levin
30 Adrian Vovk
25 Antonio Alvarez Feijoo
24 Susant Sahani
21 Topi Miettinen
20 msizanoen
19 Arseny Maslennikov
19 Ronan Pigott
17 Khem Raj
16 Ludwig Nussel
15 Maanya Goenka
13 Heinrich Schuchardt
12 Curtis Klein
12 Sam Leonard
11 Alberto Planas
11 David Rheinsberg
11 Florian Schmaus
11 rhellstrom
11 наб
10 Rafaël Kooi
10 jcg
and even that is not an accurate or good metric: the actual sources
that end up in a binary are not the only thing that matters in a
project. Documentation, manpages, unit tests, integration tests, CI,
build system, release tools, dev tools and more are just as important
to the health of a project, and are just as necessary (if not more) to
maintain it, and need active contributors. So the project-wide metric
is really the best metric to use for these kind of comparisons, for
these reasons, and for what Simon said too, of course.
