Josselin Mouette <j...@debian.org> writes: > Le lundi 07 septembre 2009 à 11:48 +0200, Bjørn Mork a écrit : >> You're not seriously suggesting that DeviceKit-disks usage of g_print >> instead of printf is actually adding anything useful? > > Yeah sure, just look at g_print and not at the other symbols used by > devkit-disks-part-id : > g_free g_slist_free g_print g_strdup g_printerr g_slist_append > g_strdup_printf g_fprintf g_vfprintf g_strchomp g_strjoinv > g_slist_length g_malloc0 g_build_filename g_file_get_contents > g_utf16_to_utf8 g_strfreev g_slist_nth_data > > Are you suggesting that such an utility should implement its own linked > list structure, and unicode translation functions?
I'm suggesting that the utility uses lots of "g_" prefixed functions while it's obvious that the author never ever evaluated the need for these. I assume that's because the author is used to them always being available. Well, in the context of udev helpers, they are not. Do you really need the g_utf16_to_utf8 unicode translation? You could just as well let udev export the raw utf16 value and leave the conversion up to the users. They may want something different than utf8 anyway. Bjørn -- To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
