-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Magnus Holmgren wrote: [...] >> The package is at >> http://littletux.homelinux.org/debian/pool/main/d/debpool/ > > Some comments: > > * You've indented the main loop in bin/debpool. While I think that's how it > should be, I also think it's best to undo it until we have merged all > contributions.
Sure. I did this to make the main loop more readable, but for merging it might be better not to indent it at first. I think that the main loop is too large anyway and should be refactored to only call a few other functions. BTW: I started a wiki page describing debpool at http://wiki.debian.org/debpool some time ago. > * SGI::FAM is not a module available in Debian, even in experimental. While [...] http://littletux.homelinux.org/debian/pool/main/libf/libfam-perl/ Simply wanted to wait for the etch release before injecting it into the perl packages svn repository ;) I am still running a 2.4 kernel on my server, so it would be good to have an alternative which does not require a 2.6 kernel. > * Did you get the init script to work? > start-stop-daemon --stop --exec /usr/bin/debpool shouldn't work, > since /proc/(pid)/exe points to /usr/bin/perl. You are right. It was a fast hack mainly to make sure that debpool *starts* after reboot :) Did you already think about the further proceeding? Shall we register a debpool2, debpool-ng or whatsoever project on alioth? Best Regards, Andreas -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFGFWRuZ3bQVzeW+rsRAi1vAKDYmYKtX31O5uOrHdQF9rmWxC3wTwCfVazo qInBSdHu0u76wjJ+TDmdstA= =xEnN -----END PGP SIGNATURE----- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
