On Tue, Sep 13, 2005 at 04:41:26AM +1000, Anthony Towns wrote: > Looking at rpmstrap-0.1, we see the following code for handling options:
Also copied was debootstrap's --arch and --include handling; even duplicating the bug where you have to say "--arch i386" (with a space) and "--include=foo,bar" (with an =). There even seems to have been a bug introduced during the copying; debootstrap has: ] --include*) ] additional="$(echo $1 | cut -f2 -d"="|tr , " ")" ] shift 1 ] ;; ] --exclude*) ] exclude="$(echo $1 | cut -f2 -d"="|tr , " ")" ] shift 1 ] ;; Someone involved in rpmstrap-0.1 evidently decided using lowercase variables in some places was unacceptably inconsistent and changed that to: ] --include*) ] ADDITIONAL="$(echo $1 | cut -f2 -d"="|tr , " ")" ] shift 1 ] ;; ] --exclude*) ] ADDITIONAL="$(echo $1 | cut -f2 -d"="|tr , " ")" ] shift 1 ] ;; making --exclude work the same as --include, up until rpmstrap-0.4, where they were changed to INCLUDES and EXCLUDES instead. rpmstrap-0.1 set an UNPACK_TARBALL variable based on an --unpack-tarball using the same code as debootstrap; but UNPACK_TARBALL is never actually used; support for it is only implemented in rpmstrap-0.2. Cheers, aj
signature.asc
Description: Digital signature
