Hi Yavor,

On Thu, 16 Nov 2006, Yavor Doganov wrote:
> It seems that this was a bug in python-adns, since today 1.1.0-2 entered
> testing and straw behaves as expected (without your patch).  I'm so
> sorry that I didn't test it with python-adns from unstable.

python-adns 1.1.0-2 doesn't fix the problem in my tests. There is only a 
fix to make it build from source again, and libadns1 version remains the 
same. A fix in python-adns would need to change ADNS.py method run or 
adnsmodule.c method ADNS_State_select. It's easy to see that when no 
adns IO is happening, it sleeps the given time because it calls select.

As the problem is a kind of starvation issue and it mostly just slows 
things down, I can accept that something has changed in your system which 
alleviates the symptoms. In any case, you might want to double-check that 
you really are testing with the unpatched straw 0.26.dsfg.1-2.

> Perhaps the maintainer should revert this NMU with the next upload, I
> don't know whether Tuukka's patch is harmless.

It's also fairly easy to see that the patch is harmless, because timeout 
only affects the time select waits, and we wait the remaining time in 
the following lines of URLFetch.py anyway, before the next run.


-- 
-- Trying to catch me? Just follow up my Electric Fingerprints
-- To help you: [EMAIL PROTECTED]
                http://www.iki.fi/Tuukka.Hastrup/


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to