Control: tag -1 + confirmed
Control: tag -1 + patch

On Fri, 18 Oct 2024 08:55:27 +0300, Niko Tyni wrote:

> This package fails its autopkgtest checks with Perl 5.40 (currently
> in unstable.)
> 
> It looks like pstoimg started warning and stderr output causes
> a test failure.
> 
>   https://ci.debian.net/packages/l/latex2html/testing/amd64/
> 
>   319s autopkgtest [00:13:05]: test command1:  - - - - - - - - - - results - 
> - - - - - - - - -
>   319s command1             FAIL stderr: Possible precedence issue with 
> control flow operator (exit) at /usr/bin/pstoimg line 874.
>   319s autopkgtest [00:13:05]: test command1:  - - - - - - - - - - stderr - - 
> - - - - - - - -
>   319s Possible precedence issue with control flow operator (exit) at 
> /usr/bin/pstoimg line 874.

>From 
>https://metacpan.org/release/HAARG/perl-5.40.0/view/pod/perldelta.pod#Changes-to-Existing-Diagnostics

Possible precedence issue with control flow operator (%s)
… Now it is also shown for misleading code like this:
    exit $x ? 0 : 1;  # actually parses as: exit($x) ? 0 : 1;
    exit $x == 0;     # actually parses as: exit($x) == 0;


Trivial patch attached.


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   
diff -Nru latex2html-2024-debian1/debian/patches/series latex2html-2024-debian1/debian/patches/series
--- latex2html-2024-debian1/debian/patches/series	2024-09-17 12:23:55.000000000 +0200
+++ latex2html-2024-debian1/debian/patches/series	2024-10-18 12:43:10.000000000 +0200
@@ -4,3 +4,4 @@
 upstream/002-fix-rootdir
 debian/remove-references-to-cweb2html
 debian/install.patch
+upstream/bug1085309
diff -Nru latex2html-2024-debian1/debian/patches/upstream/bug1085309 latex2html-2024-debian1/debian/patches/upstream/bug1085309
--- latex2html-2024-debian1/debian/patches/upstream/bug1085309	1970-01-01 01:00:00.000000000 +0100
+++ latex2html-2024-debian1/debian/patches/upstream/bug1085309	2024-10-18 12:45:27.000000000 +0200
@@ -0,0 +1,17 @@
+Description: fix warning "Possible precedence issue with control flow operator (exit) at /usr/bin/pstoimg line 874."
+Origin: vendor
+Bug-Debian: https://bugs.debian.org/1085309
+Author: gregor herrmann <gre...@debian.org>
+Last-Update: 2024-10-18
+
+--- a/pstoimg.pin
++++ b/pstoimg.pin
+@@ -969,7 +969,7 @@
+ 
+ =cut
+ 
+-exit $exit ? 1 : 0;
++exit ($exit ? 1 : 0);
+ 
+ ##############################################################################
+ # Subroutines

Attachment: signature.asc
Description: Digital Signature

Reply via email to