On Sun, Aug 11, 2024 at 12:31:21PM -0400, Reinhard Tartler wrote: > But you are right, ultimately this decision is up to the maintainer to make.
Maintainer here :) First of all, thanks to the both of you for caring enough about this package to file bugs, NMU and argue about its bugs! It's helpful to have folks contribute to it if/when I can't, and to have a diversity of opinions on what is an appropriate bugfix. Comaintainers always welcome, by the way :) Whether -Werror is appropriate for Debian package or not is a debate that goes back many years. See for example one thread out of many: https://lists.debian.org/debian-devel/2011/05/msg00658.html I see merits on both sides of this argument, but I don't think it makes sense to debate this here in the general case and in abstract. For this particular case, I think removing -Werror made sense as a quick fix to avoid kicking out the entire WasmEdge -> crun -> podman stack out of testing, for what is a bug that existed before (i.e. not a regression), and was just surfaced by a new compiler version. I had looked into the bug before Reinhard NMUed and the fix wasn't obvious to me. So taking a shortcut and prioritizing expediency over correctness made sense to me, in this particular case. But, at the same time, I agree that addressing this properly means reporting this upstream so that the underlying bug gets fixed. I see this has happened now, and upstream is already responsive (as they usually are!). There is a complicating factor, which is that we're behind an upstream version in Debian. It's good to see that upstream is looking into fixing this in the 0.13.x series. I had looked into packaging 0.14.x and it wasn't super trivial (ABI changes etc.), but that needs to happen too. Again, help is more than welcome here :) Thanks again, Faidon
