Hello Julian,

Am 03.01.24 um 22:22 schrieb Julian Gilbey:
Just to throw in: these werkzeug failures are also causing a similar
FTBFS in debugpy; I've temporarily addressed it by skipping these unit
tests, but that's not a great solution.

I just took a quick look at upgrading the unstable/testing version of
werkzeug to 2.3.8 in the meantime.  It was pretty quick, and the
package tests all pass.  Shall I upload it to unstable?

in the end it's up to you. I personally still see no real gain in doing such a version bump if we could spend the same time on fixing issues we currently see for Flask/Werkzeug >= 3.x given that we need to migrate any way in a not to far future. Why spend now time on things that could happen already within the past 6 months? What do we really gain?

And, in case you decide to upload Werkzeug 2.3.8, my guess is you will see almost the same fallout as that is still visible for the both packages with the version bump to 3.x in experimental. With one exception, it will produce pressure to fix out the issues we seen until now even more.

I worked on a lot of packages that had FTBFS or test suite issues in the past 2-3 weeks, the current queue of outstanding packages for Flask/Werkzeug 3.x is down to 5 packages. I've seen other Python team members who did also some upload to fix packages, thank you all for working on that.

https://qa.debian.org/excuses.php?experimental=1&package=python-werkzeug
https://qa.debian.org/excuses.php?experimental=1&package=flask

flask-dance (python-werkzeug)
I've done several attempts to get it build with the newer versions, it's tricky and in my opinion the upstream package isn't really ready for the newer versions.
Would need open a upstream issue about the problems to get that addressed.

onionshare (python-werkzueg)
Did not look that much yet into the culprit, might be easy to fix.
https://github.com/onionshare/onionshare/pull/1677
It's tiring to work on a active upstream project that did the last version update now more than one year ago.


beets (flask)
Fixed locally, waiting on response from Stefano due missing commits in the Salsa tree.

flask-dance (flask)
Same as above.

flask-socketio (flask)
Might be fixed by a newer upstream version, I opened a wishlist bug about updating (http://bugs.debian.org/1059538). Maybe someone can cross check?

ironic-inspector (flask)
Did not look deep into that yet. Might be fixed by a newer available upstream version. The package currently is marked for auto removal on 25th January, I guess Thomas Goirand is happily taking any help on this package.


(Incidentally, while doing this, I spotted one bug with the current
experimental version: it is missing a Build-Depends on
python3-markupsafe.)

The only requirement for Markupsafe in Flask 3.0.0 is listed in requirements/tests-pallets-min{.*}.

The build of src:flask is depending on python3-werkzeug >= 3.x, which has itself a dependency on python3-markupsafe, so if you spot a missing direct dependency I'm interested how this comes to play as Markupsafe should be around at build time.

--
Regards
Carsten

Reply via email to