Your message dated Thu, 28 Dec 2023 15:49:33 +0000
with message-id <e1risdz-00gvfe...@fasolo.debian.org>
and subject line Bug#1059565: fixed in pkg-js-tools 0.15.17
has caused the Debian Bug report #1059565,
regarding pkg-js-tools: Tests (autopkgtests) uses `fakeroot` without dependency
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1059565: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1059565
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: pkg-js-tools
Severity: serious
X-Debbugs-Cc: ni...@thykier.net
Control: affects -1 src:devscripts
Justification: Autopkgtests failures are RC per RT decision

Hi

A new version of `devscripts` removed its dependency on `fakeroot`. After this, the pkg-js-tools's autopkgtests started failing with errors like:

759s Can't exec "fakeroot": No such file or directory at /usr/share/perl5/Dpkg/IPC.pm line 312. 759s dh_eslint.t: error: unable to execute fakeroot dh_auto_install --buildsystem=nodejs: No such file or directory 759s dh_eslint.t: error: fakeroot dh_auto_install --buildsystem=nodejs subprocess returned exit status 25


https://ci.debian.net/packages/p/pkg-js-tools/testing/amd64/41355085/#L12525

This implies that `pkg-js-tools` was missing a (test) dependency on `fakeroot`. Looking a bit deeper into the tests, I think the `fakeroot` usage is unnecessary. Example from dh_badfilesfield.t:

spawn(

    exec       => [ 'fakeroot', 'dh_auto_install', '...' ],

    wait_child => 1

);


Generally, `dh_auto_install` (nor any other `debhelper` tool) does not require `fakeroot` and should be runnable without it assuming the underlying build system is ready for it (which is generally should be these days). You *may* need to set `DEB_RULES_REQUIRES_ROOT=no` to avoid triggering a safety check inside debhelper.

I would recommend that you remove all uses of `fakeroot` where possible instead of just blindly adding the depends.

Best regards,
Niels

--- End Message ---
--- Begin Message ---
Source: pkg-js-tools
Source-Version: 0.15.17
Done: Yadd <y...@debian.org>

We believe that the bug you reported is fixed in the latest version of
pkg-js-tools, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1059...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Yadd <y...@debian.org> (supplier of updated pkg-js-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 28 Dec 2023 19:36:34 +0400
Source: pkg-js-tools
Architecture: source
Version: 0.15.17
Distribution: unstable
Urgency: medium
Maintainer: Debian Javascript Maintainers 
<pkg-javascript-de...@lists.alioth.debian.org>
Changed-By: Yadd <y...@debian.org>
Closes: 1059565
Changes:
 pkg-js-tools (0.15.17) unstable; urgency=medium
 .
   * Drop test dependency to fakeroot by using Rules-Require-Root:no.
     Thanks to Niels Thykier! (Closes: #1059565)
Checksums-Sha1: 
 4ff69da550a6dbbe9cc916bbdcd9c9927c168c53 2677 pkg-js-tools_0.15.17.dsc
 4c99363e70a18554691275e1c3e2e1e1a1863f09 87776 pkg-js-tools_0.15.17.tar.xz
Checksums-Sha256: 
 ca16bb1d9c3bf49191dbc55eba9da9f9b2b7946a32f7f530e07a57f68662ac02 2677 
pkg-js-tools_0.15.17.dsc
 33e192d78068a48e05155330003eb4c5f9063e8c58a989a5ec6e5997ff88efb5 87776 
pkg-js-tools_0.15.17.tar.xz
Files: 
 3de6ff6ed098d0c8798b3bcce76b76c8 2677 devel optional pkg-js-tools_0.15.17.dsc
 09cbc5aeed4de8e59e6adf9edd2c122c 87776 devel optional 
pkg-js-tools_0.15.17.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEAN/li4tVV3nRAF7J9tdMp8mZ7ukFAmWNllkACgkQ9tdMp8mZ
7ulMnQ//R7O6NC7tFNwe7Q0OPIwhAhSVRD3LfNp9t2+TY0E91MeJZG2nrqJpfKV0
V3riyInOaOZ3ta+PP6rJvKwzq+L7noj6fUdETb5GpaE+Qlq3LR9O9NGtUwhafh0f
i6Np2SukBWDkuCzM3OwU0nqQdVHjWbnqvSE42YJOOJWPKAg+zZeWXGNet7MsX0ME
tQ6W60vmz96NjTI4Irh4oKAUTECLCpM2UpQ+9xHNDPL9DPwt04Ohx7gazF6/y0Ut
wYAct1CAsYspD5r6R5jwarXO0OKmGVOrBDZ3AsANMALgW32u0WIXuQYHSPca7H7R
W1vRp/f3oZDDao+chJeuvi3V9bswLRvkJWiT8RXxC4hfuKV82099y5cBvryK1/Ps
XrGkDKFg0AI5yOqw0j1WTTv/TG/q575cozDyIlsQzDx5JGwcxDbugp58sP40dUJe
WU5GmPV68dYMgPHBU0rDY1CBBENToV97zmYQu3rttvmKpOS27ymGqMcZD76mDgJC
lgSuDh5TAQu9i8o4gjPKCZ9GWTxsugZ67oboBZLW3HVNq7u/ZmAUo5OG+yHIaB5h
7O9RQRFHxQlYo1/woa4d0iGIHZL3f3KD9VnV14/w5k5CvG6iaZyPld0m4emc57WF
Kcv36Y47wDoPcOshfYg9IHvj+WXyUNpJj/uC/c1Yk/SCBoUGMc8=
=8Oay
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to