Your message dated Thu, 28 Dec 2023 14:39:00 +0000
with message-id <e1rirxi-00gg5s...@fasolo.debian.org>
and subject line Bug#1059565: fixed in pkg-js-tools 0.15.16
has caused the Debian Bug report #1059565,
regarding pkg-js-tools: Tests (autopkgtests) uses `fakeroot` without dependency
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1059565: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1059565
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: pkg-js-tools
Severity: serious
X-Debbugs-Cc: ni...@thykier.net
Control: affects -1 src:devscripts
Justification: Autopkgtests failures are RC per RT decision

Hi

A new version of `devscripts` removed its dependency on `fakeroot`. After this, the pkg-js-tools's autopkgtests started failing with errors like:

759s Can't exec "fakeroot": No such file or directory at /usr/share/perl5/Dpkg/IPC.pm line 312. 759s dh_eslint.t: error: unable to execute fakeroot dh_auto_install --buildsystem=nodejs: No such file or directory 759s dh_eslint.t: error: fakeroot dh_auto_install --buildsystem=nodejs subprocess returned exit status 25


https://ci.debian.net/packages/p/pkg-js-tools/testing/amd64/41355085/#L12525

This implies that `pkg-js-tools` was missing a (test) dependency on `fakeroot`. Looking a bit deeper into the tests, I think the `fakeroot` usage is unnecessary. Example from dh_badfilesfield.t:

spawn(

    exec       => [ 'fakeroot', 'dh_auto_install', '...' ],

    wait_child => 1

);


Generally, `dh_auto_install` (nor any other `debhelper` tool) does not require `fakeroot` and should be runnable without it assuming the underlying build system is ready for it (which is generally should be these days). You *may* need to set `DEB_RULES_REQUIRES_ROOT=no` to avoid triggering a safety check inside debhelper.

I would recommend that you remove all uses of `fakeroot` where possible instead of just blindly adding the depends.

Best regards,
Niels

--- End Message ---
--- Begin Message ---
Source: pkg-js-tools
Source-Version: 0.15.16
Done: Yadd <y...@debian.org>

We believe that the bug you reported is fixed in the latest version of
pkg-js-tools, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1059...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Yadd <y...@debian.org> (supplier of updated pkg-js-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 28 Dec 2023 17:54:01 +0400
Source: pkg-js-tools
Built-For-Profiles: nocheck
Architecture: source
Version: 0.15.16
Distribution: unstable
Urgency: medium
Maintainer: Debian Javascript Maintainers 
<pkg-javascript-de...@lists.alioth.debian.org>
Changed-By: Yadd <y...@debian.org>
Closes: 1059565
Changes:
 pkg-js-tools (0.15.16) unstable; urgency=medium
 .
   * pkgjs-run: keep arguments after --
   * debhelper:
     + add esbuild in webpack (to generate pkg-js.lock)
   * Update standards version to 4.6.2, no changes needed.
   * Update test dependencies: replace devscripts by fakeroot
     (Closes: #1059565)
Checksums-Sha1: 
 a6f8c1d1a2fdf06ed0ed3c0677d6cbd972556bea 2708 pkg-js-tools_0.15.16.dsc
 79cde952c01cd77c75e3705cdf3c2cdd2140a27c 87736 pkg-js-tools_0.15.16.tar.xz
Checksums-Sha256: 
 071fa85474c48c890edfd3e2cb6eb3076965e99ff0126fc0712f43e884586f56 2708 
pkg-js-tools_0.15.16.dsc
 da5139e1bc43f605c2eccebba25283e6a8f496c2b775eac99c8b8b046b94baa5 87736 
pkg-js-tools_0.15.16.tar.xz
Files: 
 9806da4322ae4564c2d58cbfaedb05d4 2708 devel optional pkg-js-tools_0.15.16.dsc
 284c34b7939d9e39eab922f66462b348 87736 devel optional 
pkg-js-tools_0.15.16.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEAN/li4tVV3nRAF7J9tdMp8mZ7ukFAmWNfjUACgkQ9tdMp8mZ
7ukCYQ/+JVbut91MOnLGhXWd4Eb2rFe89rGHiatUE1rqDIrWaue7gQZoqHje5QdF
KDTe4yNmp4l6JV7Dagzq11P4RZ+pEftK4y2QPqQZyYBq1hQu6bSWqC8b3a95oHj0
o5T/TNdqfWUlol4GxgHTYHdbFY/9kPaM8sD6BMRqv1TuM6FS3j/B1zwH/k3KdygI
hXpJgc5V1jmaMY60jYYImhFtiAaDlEr/9HVjC7Ht6bKu7bunD3xfbGz7WSiyFPuH
+I7WhvZtaU3lmVSJgCsSwhwCsEOjkBBeA9Du5djW7P62jArqUoaD48AYvVtlP6vB
LlPASw2o+sC+Yp5Fu+mbUfeoh6xdDmnzDad5NLW65lhYkrN+a1nkle5UiKIH2MMs
cpeFbsVJmuswzAuIgrlibnqk5hzDDngEyCzuvXELO7+PG5ljF3s6ByAavlSsjE8z
Iv9qfY1x7oLrrV+aNkC58h1wvh3oNu9OzY0Yt/gQ5bb0O/ZK5OY1+xkEN0xRFj8w
Td54irh6QpwBqr+1GPPXGFV0SVM4sHEfyWo6CHr9CHYFfGRoYRRdwh59MgWtY6d5
fxxEopVlabSIGtySSrdV1U7/BPwBL+zxSoVuyE2ZA4DmyTDacfKfvXznRwSfo15Q
5DR4rUs2755Eu9WJpxYwgarAOzQ7ElzhcSW0vcYSBBn/jFXFdf4=
=ey3l
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to