On Fri, 2022-09-23 at 10:45 -0400, Antoine Beaupré wrote: > Would this patch cut it? Not sure where to forward this upstream > either...
I think the problem is that HAS_CLOSEFROM is not getting defined even though the unistd.h header clearly has closefrom(). That should be fixed first. Of course the definition of the compat function should be changed to match the common definitions of closefrom() too. Your patch is missing changing the definition and implementation of closefrom in sys_compat.c, currently it is defined as returning an int and does return -1 on errors, 0 on success. PS: I note that closefrom is not in POSIX, maybe postfix should be closing individual files more manually or using close_range instead. https://www.gnu.org/software/libc/manual/html_node/Opening-and-Closing-Files.html#index-closefrom https://www.gnu.org/software//gnulib/manual/html_node/closefrom.html -- bye, pabs https://wiki.debian.org/PaulWise
signature.asc
Description: This is a digitally signed message part
