Control: tags -1 +patch

On 2022-08-14 10:46:11, Lucas Nussbaum wrote:
>> In file included from ./vstream.h:22,
>>                  from attr_print0.c:100:
>> /usr/include/unistd.h:363:13: error: conflicting types for ‘closefrom’; have 
>> ‘void(int)’
>>   363 | extern void closefrom (int __lowfd) __THROW;
>>       |             ^~~~~~~~~
>> In file included from attr_print0.c:92:
>> ./sys_defs.h:1512:12: note: previous declaration of ‘closefrom’ with type 
>> ‘int(int)’
>>  1512 | extern int closefrom(int);
>>       |            ^~~~~~~~~
>> make: *** [Makefile:212: attr_print64.o] Error 1

Would this patch cut it? Not sure where to forward this upstream
either...

-- 
Prolétaires de tous les pays, qui lave vos chaussettes?
                        - Audrey Lorde
Description: fix closefrom declaration (Closes: #1017313)
  Some change in libc (or gcc?) broke compilation of Postfix in Debian
  bookworm (coming stable). It's unclear exactly when this definition
  changed, but it's clearly breaking builds in Debian right now.
  .
  Postfix uses this function only once, and discards the return value,
  so it's effectively void anyways.  
Author: Antoine Beaupré <anar...@debian.org>
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1017313
Forwarded: no
Last-Update: 2022-09-23

--- postfix-3.6.4.orig/src/util/sys_defs.h
+++ postfix-3.6.4/src/util/sys_defs.h
@@ -1509,7 +1509,7 @@ extern int setsid(void);
 #endif
 
 #ifndef HAS_CLOSEFROM
-extern int closefrom(int);
+extern void closefrom(int);
 
 #endif
 

Reply via email to