Your message dated Fri, 29 Jul 2022 20:35:05 +0000
with message-id <e1ohwhn-0005rh...@fasolo.debian.org>
and subject line Bug#1016246: fixed in open-iscsi 2.1.7-1
has caused the Debian Bug report #1016246,
regarding open-iscsi: FTBFS: auth.c:112:34: error: the comparison will always
evaluate as ‘false’ for the address of ‘username_in’ will never be NULL
[-Werror=address]
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1016246: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1016246
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: open-iscsi
Version: 2.1.5-1
Severity: serious
Justification: FTBFS
Tags: bookworm sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20220728 ftbfs-bookworm
Hi,
During a rebuild of all packages in sid, your package failed to build
on amd64.
Relevant part (hopefully):
> cc -Wdate-time -D_FORTIFY_SOURCE=2 -Wno-error=zero-length-bounds
> -Wno-error=format-overflow= -Wno-error=format-truncation=
> -Wno-error=maybe-uninitialized -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=.
> -fstack-protector-strong -Wformat -Werror=format-security -Wall -Wextra
> -Werror -Wstrict-prototypes -fno-common -I../include -I. -D_GNU_SOURCE
> -I../libopeniscsiusr -Wdate-time -D_FORTIFY_SOURCE=2 -c -o sysfs.o sysfs.c
> auth.c: In function ‘acl_chap_auth_request’:
> auth.c:112:34: error: the comparison will always evaluate as ‘false’ for the
> address of ‘username_in’ will never be NULL [-Werror=address]
> 112 | if (session->username_in == NULL) {
> | ^~
> In file included from auth.c:36:
> initiator.h:243:14: note: ‘username_in’ declared here
> 243 | char username_in[AUTH_STR_MAX_LEN];
> | ^~~~~~~~~~~
> auth.c:125:35: error: the comparison will always evaluate as ‘false’ for the
> address of ‘password_in’ will never be NULL [-Werror=address]
> 125 | (session->password_in == NULL) ||
> | ^~
> initiator.h:244:17: note: ‘password_in’ declared here
> 244 | uint8_t password_in[AUTH_STR_MAX_LEN];
> | ^~~~~~~~~~~
> login.c: In function ‘iscsi_process_login_response’:
> login.c:660:24: error: the comparison will always evaluate as ‘true’ for the
> address of ‘auth_buffers’ will never be NULL [-Werror=address]
> 660 | auth_client = (session->auth_buffers &&
> session->num_auth_buffers) ?
> | ^~~~~~~
> In file included from login.c:34:
> initiator.h:238:33: note: ‘auth_buffers’ declared here
> 238 | struct auth_buffer_desc auth_buffers[5];
> | ^~~~~~~~~~~~
> login.c: In function ‘iscsi_make_login_pdu’:
> login.c:1138:24: error: the comparison will always evaluate as ‘true’ for the
> address of ‘auth_buffers’ will never be NULL [-Werror=address]
> 1138 | auth_client = (session->auth_buffers &&
> session->num_auth_buffers) ?
> | ^~~~~~~
> initiator.h:238:33: note: ‘auth_buffers’ declared here
> 238 | struct auth_buffer_desc auth_buffers[5];
> | ^~~~~~~~~~~~
> login.c:1173:22: error: the comparison will always evaluate as ‘true’ for the
> address of ‘target_name’ will never be NULL [-Werror=address]
> 1173 | if ((session->target_name && session->target_name[0])
> &&
> | ^~~~~~~
> initiator.h:227:14: note: ‘target_name’ declared here
> 227 | char target_name[TARGET_NAME_MAXLEN + 1];
> | ^~~~~~~~~~~
> login.c: In function ‘check_for_authentication’:
> login.c:1251:13: error: the comparison will always evaluate as ‘true’ for the
> address of ‘username’ will never be NULL [-Werror=address]
> 1251 | if (session->username &&
> | ^~~~~~~
> initiator.h:240:14: note: ‘username’ declared here
> 240 | char username[AUTH_STR_MAX_LEN];
> | ^~~~~~~~
> login.c:1258:13: error: the comparison will always evaluate as ‘true’ for the
> address of ‘password’ will never be NULL [-Werror=address]
> 1258 | if (session->password && (acl_set_passwd(auth_client,
> | ^~~~~~~
> initiator.h:241:17: note: ‘password’ declared here
> 241 | uint8_t password[AUTH_STR_MAX_LEN];
> | ^~~~~~~~
> login.c: In function ‘iscsi_login_begin’:
> login.c:1369:13: error: the comparison will always evaluate as ‘true’ for the
> address of ‘auth_buffers’ will never be NULL [-Werror=address]
> 1369 | if (session->auth_buffers && session->num_auth_buffers) {
> | ^~~~~~~
> initiator.h:238:33: note: ‘auth_buffers’ declared here
> 238 | struct auth_buffer_desc auth_buffers[5];
> | ^~~~~~~~~~~~
> cc -Wdate-time -D_FORTIFY_SOURCE=2 -Wno-error=zero-length-bounds
> -Wno-error=format-overflow= -Wno-error=format-truncation=
> -Wno-error=maybe-uninitialized -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=.
> -fstack-protector-strong -Wformat -Werror=format-security -Wall -Wextra
> -Werror -Wstrict-prototypes -fno-common -I../include -I. -D_GNU_SOURCE
> -I../libopeniscsiusr -Wdate-time -D_FORTIFY_SOURCE=2 -c -o host.o host.c
> cc -Wdate-time -D_FORTIFY_SOURCE=2 -Wno-error=zero-length-bounds
> -Wno-error=format-overflow= -Wno-error=format-truncation=
> -Wno-error=maybe-uninitialized -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=.
> -fstack-protector-strong -Wformat -Werror=format-security -Wall -Wextra
> -Werror -Wstrict-prototypes -fno-common -I../include -I. -D_GNU_SOURCE
> -I../libopeniscsiusr -Wdate-time -D_FORTIFY_SOURCE=2 -c -o session_info.o
> session_info.c
> cc -Wdate-time -D_FORTIFY_SOURCE=2 -Wno-error=zero-length-bounds
> -Wno-error=format-overflow= -Wno-error=format-truncation=
> -Wno-error=maybe-uninitialized -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=.
> -fstack-protector-strong -Wformat -Werror=format-security -Wall -Wextra
> -Werror -Wstrict-prototypes -fno-common -I../include -I. -D_GNU_SOURCE
> -I../libopeniscsiusr -Wdate-time -D_FORTIFY_SOURCE=2 -c -o iscsi_sysfs.o
> iscsi_sysfs.c
> cc -Wdate-time -D_FORTIFY_SOURCE=2 -Wno-error=zero-length-bounds
> -Wno-error=format-overflow= -Wno-error=format-truncation=
> -Wno-error=maybe-uninitialized -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=.
> -fstack-protector-strong -Wformat -Werror=format-security -Wall -Wextra
> -Werror -Wstrict-prototypes -fno-common -I../include -I. -D_GNU_SOURCE
> -I../libopeniscsiusr -Wdate-time -D_FORTIFY_SOURCE=2 -c -o iscsid_req.o
> iscsid_req.c
> cc -Wdate-time -D_FORTIFY_SOURCE=2 -Wno-error=zero-length-bounds
> -Wno-error=format-overflow= -Wno-error=format-truncation=
> -Wno-error=maybe-uninitialized -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=.
> -fstack-protector-strong -Wformat -Werror=format-security -Wall -Wextra
> -Werror -Wstrict-prototypes -fno-common -I../include -I. -D_GNU_SOURCE
> -I../libopeniscsiusr -Wdate-time -D_FORTIFY_SOURCE=2 -c -o transport.o
> transport.c
> iscsi_sysfs.c: In function ‘iscsi_sysfs_get_sessioninfo_by_id’:
> iscsi_sysfs.c:1419:51: error: the comparison will always evaluate as ‘true’
> for the address of ‘address’ will never be NULL [-Werror=address]
> 1419 | info->targetname, info->address ? info->address :
> "NA",
> | ^
> In file included from iscsi_sysfs.c:39:
> session_info.h:41:14: note: ‘address’ declared here
> 41 | char address[NI_MAXHOST + 1];
> | ^~~~~~~
> iscsi_sysfs.c:1420:44: error: the comparison will always evaluate as ‘true’
> for the address of ‘persistent_address’ will never be NULL [-Werror=address]
> 1420 | info->persistent_address ? info->persistent_address
> : "NA",
> | ^
> session_info.h:43:14: note: ‘persistent_address’ declared here
> 43 | char persistent_address[NI_MAXHOST + 1];
> | ^~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> make[3]: *** [<builtin>: auth.o] Error 1
The full build log is available from:
http://qa-logs.debian.net/2022/07/28/open-iscsi_2.1.5-1_unstable.log
All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20220728;users=lu...@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20220728&fusertaguser=lu...@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results
A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!
If you reassign this bug to another package, please marking it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects
If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.
--- End Message ---
--- Begin Message ---
Source: open-iscsi
Source-Version: 2.1.7-1
Done: Chris Hofstaedtler <z...@debian.org>
We believe that the bug you reported is fixed in the latest version of
open-iscsi, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1016...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Chris Hofstaedtler <z...@debian.org> (supplier of updated open-iscsi package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Fri, 29 Jul 2022 19:59:11 +0000
Source: open-iscsi
Architecture: source
Version: 2.1.7-1
Distribution: unstable
Urgency: medium
Maintainer: Debian iSCSI Maintainers <open-is...@packages.debian.org>
Changed-By: Chris Hofstaedtler <z...@debian.org>
Closes: 982307 1004014 1016246
Changes:
open-iscsi (2.1.7-1) unstable; urgency=medium
.
* [3050096] New upstream version 2.1.7 (Closes: #982307, #1016246)
* [46fd279] Refresh patches, drop upstream applied ftbfs patch
* [cac01da] Help upstream Makefile find sed in /bin
* [0202184] Add patches from upstream master to fix build
* [f61e6a0] Use dh_auto_install, better suits new upstream build system
* [2080bfb] Fix multiarch install location
* [4f57eb7] Move udeb files into correct places (like in 2.0.874-7.1)
* [75b86ce] Cleanup duplicate override_dh_installsystemd section
(Closes: #1004014)
* [24f9981] d/copyright: update
* [41970e3] Rely on dh_installinitramfs to install triggers
Checksums-Sha1:
74463ad6afbd025e7b6aceded6de3929f7a5c8b1 2585 open-iscsi_2.1.7-1.dsc
da11ca06021ced87cd537fe7248612db404fa24c 627848 open-iscsi_2.1.7.orig.tar.gz
5e0ce69e429f933fc245ad75329c981d71bbd9a3 56792 open-iscsi_2.1.7-1.debian.tar.xz
1e167f9cef5e5c9ead99c37bf3c5dea8b42c11a7 6971
open-iscsi_2.1.7-1_source.buildinfo
Checksums-Sha256:
a76f684e4fa14b58d7b631a452686e4c2a34223f97fbdaf57898c7f77fc3efbe 2585
open-iscsi_2.1.7-1.dsc
d96761e47a69f8214c5fbd251d844f37961b14c3e437b63a15cc64f5b8cba2f0 627848
open-iscsi_2.1.7.orig.tar.gz
92a261e059853c81fe1ddec4099f0b16ccba5dd4a14f27d786cd5b0848c395c3 56792
open-iscsi_2.1.7-1.debian.tar.xz
9b60d28ba6938ac4c2c34a23f7ded848efc256ed9bbbede27f1ba0fdd90036b7 6971
open-iscsi_2.1.7-1_source.buildinfo
Files:
f9f3c54633898953bb0e9e039953ce86 2585 net optional open-iscsi_2.1.7-1.dsc
87f37b0968ff91ed0253d53d497da4cb 627848 net optional
open-iscsi_2.1.7.orig.tar.gz
720e8a268d55e182acccf2cfcdbd91f7 56792 net optional
open-iscsi_2.1.7-1.debian.tar.xz
ea2f1462eb7a1a10fd264ca464a6c331 6971 net optional
open-iscsi_2.1.7-1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEfRrP+tnggGycTNOSXBPW25MFLgMFAmLkQLAACgkQXBPW25MF
LgPzPw/+M26YgXqKleKEU3DpyiOTK4Km3UqTpUcyUttpqqGfcznsU0p8yvrz7xqQ
FqKmVyJ9MsAeSwf8bYvNvqB7JIbOwV+B3bjw+PUtsYcxX9eM1w7TNR7JbGWPwKl2
H6elVEYP8zjrMsaoCjwnon6Ue9z+xpHzcfpcvDwbqiBSSx4HK87885CrTEt2mrO8
g/B8PLb3pSISG0sNpEF+RXEk5G643FW8E0TVjGjGjFjQBLCnbaWkpPUcPONsuI4h
SHmWtmc5wXB/43cgXZo7UtsFUyfJaQ9yFRBrRCBzV4GUIjrYZ+KkDPcOMLZfe1lE
rq1xImm70etHIine6LOCWsPrg5ko9Box2uTX4UWGWQWbdhtKN7h0S6Us+148fuZL
sW+B1/y1LNNyfwAwD9bhaPnUUuIHbxMfwscgYj9nrRwyq3ECS35SF+o9iyVAjAuy
nEkfhhiamV7/rA7F4B/BETz7RcUFBn9mFJSezekF7rCzATI5BhNF3h14y4baw7ly
Z2Ds6psLRLKHa/3PzN6cNe2FXyiO9NwBqjT87Se7VGq2HbezIGuhHYR4EmzSMo1x
nfTCKZxIBk4bqRSLJ0xUZwK3tdNY0yO0lso+GP8ZUuuyUJbZU7A9dtU5VZCrAGPQ
DkUwTplA5iKxXWBOY2IorV/5e2GT8MEmQ6iHD0N7oN94KcjmYvY=
=O6Fv
-----END PGP SIGNATURE-----
--- End Message ---
