Source: open-iscsi
Version: 2.1.5-1
Severity: serious
Justification: FTBFS
Tags: bookworm sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20220728 ftbfs-bookworm
Hi,
During a rebuild of all packages in sid, your package failed to build
on amd64.
Relevant part (hopefully):
> cc -Wdate-time -D_FORTIFY_SOURCE=2 -Wno-error=zero-length-bounds
> -Wno-error=format-overflow= -Wno-error=format-truncation=
> -Wno-error=maybe-uninitialized -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=.
> -fstack-protector-strong -Wformat -Werror=format-security -Wall -Wextra
> -Werror -Wstrict-prototypes -fno-common -I../include -I. -D_GNU_SOURCE
> -I../libopeniscsiusr -Wdate-time -D_FORTIFY_SOURCE=2 -c -o sysfs.o sysfs.c
> auth.c: In function ‘acl_chap_auth_request’:
> auth.c:112:34: error: the comparison will always evaluate as ‘false’ for the
> address of ‘username_in’ will never be NULL [-Werror=address]
> 112 | if (session->username_in == NULL) {
> | ^~
> In file included from auth.c:36:
> initiator.h:243:14: note: ‘username_in’ declared here
> 243 | char username_in[AUTH_STR_MAX_LEN];
> | ^~~~~~~~~~~
> auth.c:125:35: error: the comparison will always evaluate as ‘false’ for the
> address of ‘password_in’ will never be NULL [-Werror=address]
> 125 | (session->password_in == NULL) ||
> | ^~
> initiator.h:244:17: note: ‘password_in’ declared here
> 244 | uint8_t password_in[AUTH_STR_MAX_LEN];
> | ^~~~~~~~~~~
> login.c: In function ‘iscsi_process_login_response’:
> login.c:660:24: error: the comparison will always evaluate as ‘true’ for the
> address of ‘auth_buffers’ will never be NULL [-Werror=address]
> 660 | auth_client = (session->auth_buffers &&
> session->num_auth_buffers) ?
> | ^~~~~~~
> In file included from login.c:34:
> initiator.h:238:33: note: ‘auth_buffers’ declared here
> 238 | struct auth_buffer_desc auth_buffers[5];
> | ^~~~~~~~~~~~
> login.c: In function ‘iscsi_make_login_pdu’:
> login.c:1138:24: error: the comparison will always evaluate as ‘true’ for the
> address of ‘auth_buffers’ will never be NULL [-Werror=address]
> 1138 | auth_client = (session->auth_buffers &&
> session->num_auth_buffers) ?
> | ^~~~~~~
> initiator.h:238:33: note: ‘auth_buffers’ declared here
> 238 | struct auth_buffer_desc auth_buffers[5];
> | ^~~~~~~~~~~~
> login.c:1173:22: error: the comparison will always evaluate as ‘true’ for the
> address of ‘target_name’ will never be NULL [-Werror=address]
> 1173 | if ((session->target_name && session->target_name[0])
> &&
> | ^~~~~~~
> initiator.h:227:14: note: ‘target_name’ declared here
> 227 | char target_name[TARGET_NAME_MAXLEN + 1];
> | ^~~~~~~~~~~
> login.c: In function ‘check_for_authentication’:
> login.c:1251:13: error: the comparison will always evaluate as ‘true’ for the
> address of ‘username’ will never be NULL [-Werror=address]
> 1251 | if (session->username &&
> | ^~~~~~~
> initiator.h:240:14: note: ‘username’ declared here
> 240 | char username[AUTH_STR_MAX_LEN];
> | ^~~~~~~~
> login.c:1258:13: error: the comparison will always evaluate as ‘true’ for the
> address of ‘password’ will never be NULL [-Werror=address]
> 1258 | if (session->password && (acl_set_passwd(auth_client,
> | ^~~~~~~
> initiator.h:241:17: note: ‘password’ declared here
> 241 | uint8_t password[AUTH_STR_MAX_LEN];
> | ^~~~~~~~
> login.c: In function ‘iscsi_login_begin’:
> login.c:1369:13: error: the comparison will always evaluate as ‘true’ for the
> address of ‘auth_buffers’ will never be NULL [-Werror=address]
> 1369 | if (session->auth_buffers && session->num_auth_buffers) {
> | ^~~~~~~
> initiator.h:238:33: note: ‘auth_buffers’ declared here
> 238 | struct auth_buffer_desc auth_buffers[5];
> | ^~~~~~~~~~~~
> cc -Wdate-time -D_FORTIFY_SOURCE=2 -Wno-error=zero-length-bounds
> -Wno-error=format-overflow= -Wno-error=format-truncation=
> -Wno-error=maybe-uninitialized -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=.
> -fstack-protector-strong -Wformat -Werror=format-security -Wall -Wextra
> -Werror -Wstrict-prototypes -fno-common -I../include -I. -D_GNU_SOURCE
> -I../libopeniscsiusr -Wdate-time -D_FORTIFY_SOURCE=2 -c -o host.o host.c
> cc -Wdate-time -D_FORTIFY_SOURCE=2 -Wno-error=zero-length-bounds
> -Wno-error=format-overflow= -Wno-error=format-truncation=
> -Wno-error=maybe-uninitialized -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=.
> -fstack-protector-strong -Wformat -Werror=format-security -Wall -Wextra
> -Werror -Wstrict-prototypes -fno-common -I../include -I. -D_GNU_SOURCE
> -I../libopeniscsiusr -Wdate-time -D_FORTIFY_SOURCE=2 -c -o session_info.o
> session_info.c
> cc -Wdate-time -D_FORTIFY_SOURCE=2 -Wno-error=zero-length-bounds
> -Wno-error=format-overflow= -Wno-error=format-truncation=
> -Wno-error=maybe-uninitialized -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=.
> -fstack-protector-strong -Wformat -Werror=format-security -Wall -Wextra
> -Werror -Wstrict-prototypes -fno-common -I../include -I. -D_GNU_SOURCE
> -I../libopeniscsiusr -Wdate-time -D_FORTIFY_SOURCE=2 -c -o iscsi_sysfs.o
> iscsi_sysfs.c
> cc -Wdate-time -D_FORTIFY_SOURCE=2 -Wno-error=zero-length-bounds
> -Wno-error=format-overflow= -Wno-error=format-truncation=
> -Wno-error=maybe-uninitialized -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=.
> -fstack-protector-strong -Wformat -Werror=format-security -Wall -Wextra
> -Werror -Wstrict-prototypes -fno-common -I../include -I. -D_GNU_SOURCE
> -I../libopeniscsiusr -Wdate-time -D_FORTIFY_SOURCE=2 -c -o iscsid_req.o
> iscsid_req.c
> cc -Wdate-time -D_FORTIFY_SOURCE=2 -Wno-error=zero-length-bounds
> -Wno-error=format-overflow= -Wno-error=format-truncation=
> -Wno-error=maybe-uninitialized -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=.
> -fstack-protector-strong -Wformat -Werror=format-security -Wall -Wextra
> -Werror -Wstrict-prototypes -fno-common -I../include -I. -D_GNU_SOURCE
> -I../libopeniscsiusr -Wdate-time -D_FORTIFY_SOURCE=2 -c -o transport.o
> transport.c
> iscsi_sysfs.c: In function ‘iscsi_sysfs_get_sessioninfo_by_id’:
> iscsi_sysfs.c:1419:51: error: the comparison will always evaluate as ‘true’
> for the address of ‘address’ will never be NULL [-Werror=address]
> 1419 | info->targetname, info->address ? info->address :
> "NA",
> | ^
> In file included from iscsi_sysfs.c:39:
> session_info.h:41:14: note: ‘address’ declared here
> 41 | char address[NI_MAXHOST + 1];
> | ^~~~~~~
> iscsi_sysfs.c:1420:44: error: the comparison will always evaluate as ‘true’
> for the address of ‘persistent_address’ will never be NULL [-Werror=address]
> 1420 | info->persistent_address ? info->persistent_address
> : "NA",
> | ^
> session_info.h:43:14: note: ‘persistent_address’ declared here
> 43 | char persistent_address[NI_MAXHOST + 1];
> | ^~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> make[3]: *** [<builtin>: auth.o] Error 1
The full build log is available from:
http://qa-logs.debian.net/2022/07/28/open-iscsi_2.1.5-1_unstable.log
All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20220728;users=lu...@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20220728&fusertaguser=lu...@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results
A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!
If you reassign this bug to another package, please marking it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects
If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.
