Your message dated Thu, 06 Jan 2022 18:33:38 +0000
with message-id <e1n5xzy-000ixn...@fasolo.debian.org>
and subject line Bug#995393: fixed in fakeroot 1.26-1.2
has caused the Debian Bug report #995393,
regarding fakeroot: FTBFS on ppc64el
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
995393: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=995393
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: src:fakeroot
Version: 1.26-1
Control: tags -1 ftbfs

--

Dear maintainer,
fakeroot fails to build on ppc64el since 1.26-1
https://buildd.debian.org/status/fetch.php?pkg=fakeroot&arch=ppc64el&ver=1.26-1&stamp=1630982822&raw=0

Backtrace from the core file :
---
Core was generated by `chown -R daemon:sys 2 '.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x000005e13c212284 in 0000001b.plt_call.fdopendir@@GLIBC_2.17 ()
(gdb) bt
#0  0x000005e13c212284 in 0000001b.plt_call.fdopendir@@GLIBC_2.17 ()
#1  0x000005e13c220fd4 in opendirat (dir_fd=-100, dir=0x5e13fb347b0 "2", 
extra_flags=32768, pnew_fd=0x7fffc6e5cab0) at lib/opendirat.c:44
#2  0x000005e13c21cb74 in fts_build (sp=0x5e13fb33ce0, type=3) at lib/fts.c:1340
#3  0x000005e13c21be60 in rpl_fts_read (sp=0x5e13fb33ce0) at lib/fts.c:940
#4  0x000005e13c214ca0 in chown_files (files=0x7fffc6e5d210, bit_flags=1040, 
uid=1, gid=3, required_uid=4294967295, required_gid=4294967295, 
chopt=0x7fffc6e5cd00) at src/chown-core.c:531
#5  0x000005e13c21349c in main (argc=4, argv=0x7fffc6e5d1f8) at src/chown.c:324
---

Bisecting the code I ended up with this commit : 
https://salsa.debian.org/clint/fakeroot/-/commit/f5e0a89ab6f0024f3d3bec5fd9cf631676b44f6c
from which things start to fail.
Especially the openat() function.
What I noticed also is that lowering optimization to O0 makes the test
work.

Simple way to reproduce is on directories : 
---
mkdir bla
LD_PRELOAD=./obj-sysv/.libs/libfakeroot-0.so /bin/rm -fr bla
---
Each time fdopendir seg fault with the fd coming from openat right
before.

Not sure what optimization breaks, I just tried changing openat() to
modify some aggressive optimization on that function and it helped.

---
--- a/libfakeroot.c
+++ b/libfakeroot.c
@@ -2596,7 +2596,11 @@
 #endif
 
 #ifdef HAVE_OPENAT
+#if defined(__powerpc__) && defined(__powerpc64__) && __BYTE_ORDER__ == 
__ORDER_LITTLE_ENDIAN__
+static int openat(int dir_fd, const char *pathname, int flags, ...)
+#else
 int openat(int dir_fd, const char *pathname, int flags, ...)
+#endif
 {
        mode_t mode;
---

Hoping you'll get more ideas on this


Regards,


F.

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message ---
Source: fakeroot
Source-Version: 1.26-1.2
Done: Christoph Biedl <debian.a...@manchmal.in-ulm.de>

We believe that the bug you reported is fixed in the latest version of
fakeroot, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 995...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Christoph Biedl <debian.a...@manchmal.in-ulm.de> (supplier of updated fakeroot 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 03 Jan 2022 18:49:27 +0100
Source: fakeroot
Architecture: source
Version: 1.26-1.2
Distribution: unstable
Urgency: high
Maintainer: Clint Adams <cl...@debian.org>
Changed-By: Christoph Biedl <debian.a...@manchmal.in-ulm.de>
Closes: 995393
Changes:
 fakeroot (1.26-1.2) unstable; urgency=high
 .
   * Non-maintainer upload
   * Fix segfault on ppc64el, take 2. Closes: #995393
Checksums-Sha1:
 fcc3f22f4748c6e765325d5ac2e15c94b97c54ff 1943 fakeroot_1.26-1.2.dsc
 ecb4df3628ecf031f8cea91f69d27522ccc27c5e 24344 fakeroot_1.26-1.2.debian.tar.xz
 47a3ccd6e768cd2a1d682ffeaed49dce29587a4d 6747 
fakeroot_1.26-1.2_powerpc.buildinfo
Checksums-Sha256:
 4bd3f71af2f6e9feba037ba2b91ccfad96a56ee896d3308a6452c91bd4d62404 1943 
fakeroot_1.26-1.2.dsc
 6cc9f6b1855aaa81928dc15ecaaa4525d61ce6f731b07cc1eba5b21da1e6e94c 24344 
fakeroot_1.26-1.2.debian.tar.xz
 0ad2b944d3c2618d46fc64bedcf01b98133e76c64ac79e3c375424cea1652c8e 6747 
fakeroot_1.26-1.2_powerpc.buildinfo
Files:
 d32b681f2d4381308f84ad74166c6159 1943 utils optional fakeroot_1.26-1.2.dsc
 83c4425eef0b8651128714bbedbf6057 24344 utils optional 
fakeroot_1.26-1.2.debian.tar.xz
 c62d09e9c7217320cb23efafeb6ab52f 6747 utils optional 
fakeroot_1.26-1.2_powerpc.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEWXMI+726A12MfJXdxCxY61kUkv0FAmHTO38ACgkQxCxY61kU
kv35ChAAuHeYzIodjopoKOYCFOtmU04k6oTwW+EzlQ8dcmIHhI9Hm35oYHEKA5M0
LcERphyswqWcC7t+bQEH8tj/g65d1DjGXTcc/78wV8qJJ2Qvq1eAUh3Iz60Jcbyl
SZccmR3C4s+nO6YNVQyuYI34bCMBnrZOBDM38qDQUhD2CCM1jTFXKPccRSYnySRN
N45m3U8BotEJ7gnZdt0iDTe/X+Ha0MWTWDv7+3KuqmAWGrq+58QxuaExzpChWSjR
ScX/Cavki+Dvz5EqBgsIX4Ul0nUVdUeoajLb8w/W3WyY60GOusxE36wMim/JvNOo
OWz6lOz7T4r62F6Z1s/oec8g//Tuz7viHrdP8XTzeWjSCNEvpESiuYmahmTDeQsZ
Bnv6RapzNltk84Gk0HPcs7OVY7rg+BGiPIsgOLHVaBIjvC2+fhTiqm8AUjCNxjF8
WWjVgUe57JJivNhVEuAUuSXnb1VbSq3WSYGcEQtlyDSFlWpjzpZwMKkqay7ONuXK
6euKWMhYeCce+txUTAt4ckQyt0k3EzymOknaWymq0CsM6pxXL4e1L0845K4B3yfM
SoVFjc4FQGvSYHUM/Ab6qsQZ+yEiScXm9uyMEn4yLEjUvxAXrP6Qs6bsrklPKwd4
C9dWc/tLhR3YsP5kqQSpayG1uu2HyPPKSIcNY7jofJHh5ZSMgA4=
=etB0
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to