Your message dated Sun, 26 Dec 2021 23:03:37 +0000
with message-id <e1n1cyd-000feb...@fasolo.debian.org>
and subject line Bug#995393: fixed in fakeroot 1.26-1.1
has caused the Debian Bug report #995393,
regarding fakeroot: FTBFS on ppc64el
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
995393: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=995393
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: src:fakeroot
Version: 1.26-1
Control: tags -1 ftbfs

--

Dear maintainer,
fakeroot fails to build on ppc64el since 1.26-1
https://buildd.debian.org/status/fetch.php?pkg=fakeroot&arch=ppc64el&ver=1.26-1&stamp=1630982822&raw=0

Backtrace from the core file :
---
Core was generated by `chown -R daemon:sys 2 '.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x000005e13c212284 in 0000001b.plt_call.fdopendir@@GLIBC_2.17 ()
(gdb) bt
#0  0x000005e13c212284 in 0000001b.plt_call.fdopendir@@GLIBC_2.17 ()
#1  0x000005e13c220fd4 in opendirat (dir_fd=-100, dir=0x5e13fb347b0 "2", 
extra_flags=32768, pnew_fd=0x7fffc6e5cab0) at lib/opendirat.c:44
#2  0x000005e13c21cb74 in fts_build (sp=0x5e13fb33ce0, type=3) at lib/fts.c:1340
#3  0x000005e13c21be60 in rpl_fts_read (sp=0x5e13fb33ce0) at lib/fts.c:940
#4  0x000005e13c214ca0 in chown_files (files=0x7fffc6e5d210, bit_flags=1040, 
uid=1, gid=3, required_uid=4294967295, required_gid=4294967295, 
chopt=0x7fffc6e5cd00) at src/chown-core.c:531
#5  0x000005e13c21349c in main (argc=4, argv=0x7fffc6e5d1f8) at src/chown.c:324
---

Bisecting the code I ended up with this commit : 
https://salsa.debian.org/clint/fakeroot/-/commit/f5e0a89ab6f0024f3d3bec5fd9cf631676b44f6c
from which things start to fail.
Especially the openat() function.
What I noticed also is that lowering optimization to O0 makes the test
work.

Simple way to reproduce is on directories : 
---
mkdir bla
LD_PRELOAD=./obj-sysv/.libs/libfakeroot-0.so /bin/rm -fr bla
---
Each time fdopendir seg fault with the fd coming from openat right
before.

Not sure what optimization breaks, I just tried changing openat() to
modify some aggressive optimization on that function and it helped.

---
--- a/libfakeroot.c
+++ b/libfakeroot.c
@@ -2596,7 +2596,11 @@
 #endif
 
 #ifdef HAVE_OPENAT
+#if defined(__powerpc__) && defined(__powerpc64__) && __BYTE_ORDER__ == 
__ORDER_LITTLE_ENDIAN__
+static int openat(int dir_fd, const char *pathname, int flags, ...)
+#else
 int openat(int dir_fd, const char *pathname, int flags, ...)
+#endif
 {
        mode_t mode;
---

Hoping you'll get more ideas on this


Regards,


F.

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message ---
Source: fakeroot
Source-Version: 1.26-1.1
Done: Christoph Biedl <debian.a...@manchmal.in-ulm.de>

We believe that the bug you reported is fixed in the latest version of
fakeroot, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 995...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Christoph Biedl <debian.a...@manchmal.in-ulm.de> (supplier of updated fakeroot 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 23 Dec 2021 08:19:30 +0100
Source: fakeroot
Architecture: source
Version: 1.26-1.1
Distribution: unstable
Urgency: high
Maintainer: Clint Adams <cl...@debian.org>
Changed-By: Christoph Biedl <debian.a...@manchmal.in-ulm.de>
Closes: 995393 1001961
Changes:
 fakeroot (1.26-1.1) unstable; urgency=high
 .
   * Non-maintainer upload
   * Also wrap the "stat" library call. Closes: #1001961
   * Work around segfault on ppc64el. Closes: #995393
Checksums-Sha1:
 bcce536e653df5409650e2d878c9bd81f23815d6 1943 fakeroot_1.26-1.1.dsc
 03451fac5d1530cea7306a245736359313006017 23848 fakeroot_1.26-1.1.debian.tar.xz
 3e26131363c810b081384ec3651a7e9ae2e1e470 6735 
fakeroot_1.26-1.1_powerpc.buildinfo
Checksums-Sha256:
 5afda00346347b7de942b04f72bb51004a6f1134f9decdfb223f3d0ea2656231 1943 
fakeroot_1.26-1.1.dsc
 8f8dec5adfcbc6c7eec64ea67258da57a6b571177f4fa2040e0496b0e30b7ab4 23848 
fakeroot_1.26-1.1.debian.tar.xz
 2695189387c73222e0f72bb6e2800ddb062a863630d42a61151991925bc3817e 6735 
fakeroot_1.26-1.1_powerpc.buildinfo
Files:
 f5c4a5af0146aede185b8aaca158c88d 1943 utils optional fakeroot_1.26-1.1.dsc
 673c0d4ec89b04de60331900c0474a3b 23848 utils optional 
fakeroot_1.26-1.1.debian.tar.xz
 f1c35ca6845f7795de9b8679b7bba058 6735 utils optional 
fakeroot_1.26-1.1_powerpc.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEWXMI+726A12MfJXdxCxY61kUkv0FAmHE4kUACgkQxCxY61kU
kv2fug//cXefGarGYBamOLBck1UBcP8FusoCIiz3iFvQlFnKZ8uPJlOEjzbpjIMa
keExyGhB7rf+Mhh6beeG+AfnGAelvbNIQuXf5cdj0s+cCb2ZiZf8oRcgNpObkYKD
MQ9NjIqD5FnoqKpxKdtoitwG0aFITvlbuNABwko1/pLAIcTIGLpNZhbH0t7A41or
T7zx+DsHoOu3ySHqEewfroqYovm8qeZzZKhhD2MYEqkbvsKJ7zwJ5KTdT076KgeN
fSW20cSW9grrGi8OCzHXIM6GsKDdoFEBaBq21PIgFGzQ0YgA/r9CLP2qSZMJ5rqm
Ple9gEu/L8pQP3vDWIO2gm2TP9v7+Uky4TSNaqwq90CL+PKPbh4tmplrlivuQ4hO
KBXHsjLB8SsZRjGlLhwEvnikQc/hiODM5MUFlpjFHE7Eyk2q5fCYdWw4H8TsUux6
jD0AJL+aRamgcUTqSjFrKNnheQols2UH/Ziy1ZKGs9wVuXi5g+7Yl95JB5A9eI05
MGblBP/7OsiQBoR2Z+Y2Jo7bVqMjsH/ArgfHMIXuy0mTleCb6rCRVdDkC3YuCnuU
8m8C/XK+VE5agAfl5JcYclKYp1bROfCo8sRJ+Lw/y1eXrymEQnzsT1eUdErHsvWd
2kp9V8/P6FvCcdqspZO6YdB1Uk8rk/Dy1WybEC/glQsAzKVO2lk=
=ACds
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to