Your message dated Sun, 07 Jul 2019 07:55:28 +0000 with message-id <e1hk21a-000gyz...@fasolo.debian.org> and subject line Bug#931492: fixed in verilator 4.016-3 has caused the Debian Bug report #931492, regarding verilator: please honour CFLAGS and CXXFLAGS to build to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 931492: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=931492 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Source: verilator Version: 4.016-2 Severity: serious Tags: patch experimental Hello, looks like the new dwz from experimental makes verilator FTBFS, see: https://bugs.launchpad.net/ubuntu/+source/dwz/+bug/1835398 reason is: debug flags are not injected to every package that is built, and the new dwz in experimental fails to compress them. the attached patch fixes the build failure (that is showing only in experimental, for now) thanks for accepting, I sent it by email also upstream some minutes ago. G.Description: Honour system flags, this makes debug flags being injected correctly Author: Gianfranco Costamagna <locutusofb...@debian.org> Last-Update: 2019-07-06 --- verilator-4.016.orig/configure.ac +++ verilator-4.016/configure.ac @@ -91,10 +91,10 @@ AC_SUBST(CFG_WITH_PREC11) AC_MSG_RESULT($CFG_WITH_PREC11) # Compiler flags -CFLAGS=-I${includedir} -CPPFLAGS=-I${includedir} -CXXFLAGS=-I${includedir} -LDFLAGS=-L${libdir} +CFLAGS+=" -I${includedir}" +CPPFLAGS+=" -I${includedir}" +CXXFLAGS+=" -I${includedir}" +LDFLAGS+=" -L${libdir}" # Checks for programs. AC_PROG_CC --- verilator-4.016.orig/src/Makefile_obj.in +++ verilator-4.016/src/Makefile_obj.in @@ -60,6 +60,8 @@ pkgdatadir = @pkgdatadir@ CFG_WITH_CCWARN = @CFG_WITH_CCWARN@ CFG_WITH_DEFENV = @CFG_WITH_DEFENV@ CPPFLAGS += @CPPFLAGS@ +CFLAGS += @CFLAGS@ +CXXFLAGS += @CXXFLAGS@ LDFLAGS += @LDFLAGS@ EXEEXT = @EXEEXT@ CFG_CXXFLAGS_SRC = @CFG_CXXFLAGS_SRC@ @@ -135,7 +137,7 @@ VLCOVGEN = $(srcdir)/vlcovgen all: make_info $(TGT) make_info: - @echo " Compile flags: " $(CXX) ${CPPFLAGS} + @echo " Compile flags: " $(CXX) ${CFLAGS} ${CXXFLAGS} ${CPPFLAGS} clean mostlyclean distclean maintainer-clean:: -rm -f *.o *.d perlxsi.c *_gen_* @@ -280,21 +282,21 @@ V3Number_test: V3Number_test.o $(PERL) $(ASTGEN) -I$(srcdir) $*.cpp %.o: %.cpp - $(OBJCACHE) ${CXX} ${CPPFLAGSWALL} -c $< + $(OBJCACHE) ${CXX} ${CXXFLAGS} ${CPPFLAGSWALL} -c $< %.o: %.c - $(OBJCACHE) ${CC} ${CPPFLAGSWALL} -c $< + $(OBJCACHE) ${CC} ${CFLAGS} ${CPPFLAGSWALL} -c $< V3ParseLex.o: V3ParseLex.cpp V3Lexer.yy.cpp V3ParseBison.c - $(OBJCACHE) ${CXX} ${CPPFLAGSPARSER} -c $< + $(OBJCACHE) ${CXX} ${CXXFLAGS} ${CPPFLAGSPARSER} -c $< V3ParseGrammar.o: V3ParseGrammar.cpp V3ParseBison.c - $(OBJCACHE) ${CXX} ${CPPFLAGSPARSER} -c $< + $(OBJCACHE) ${CXX} ${CXXFLAGS} ${CPPFLAGSPARSER} -c $< V3ParseImp.o: V3ParseImp.cpp V3ParseBison.c - $(OBJCACHE) ${CXX} ${CPPFLAGSPARSER} -c $< + $(OBJCACHE) ${CXX} ${CXXFLAGS} ${CPPFLAGSPARSER} -c $< V3PreProc.o: V3PreProc.cpp V3PreLex.yy.cpp - $(OBJCACHE) ${CXX} ${CPPFLAGSPARSER} -c $< + $(OBJCACHE) ${CXX} ${CXXFLAGS} ${CPPFLAGSPARSER} -c $< #### Generated files
--- End Message ---
--- Begin Message ---Source: verilator Source-Version: 4.016-3 We believe that the bug you reported is fixed in the latest version of verilator, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 931...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. أحمد المحمودي (Ahmed El-Mahmoudy) <aelmahmo...@users.sourceforge.net> (supplier of updated verilator package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Sun, 07 Jul 2019 02:53:30 +0200 Source: verilator Binary: verilator Architecture: source Version: 4.016-3 Distribution: unstable Urgency: medium Maintainer: Debian Electronics Team <pkg-electronics-de...@lists.alioth.debian.org> Changed-By: أحمد المحمودي (Ahmed El-Mahmoudy) <aelmahmo...@users.sourceforge.net> Description: verilator - fast free Verilog simulator Closes: 931492 Changes: verilator (4.016-3) unstable; urgency=medium . * Add system-flags.diff patch to honour system flags. (Closes: #931492) Thanks to Gianfranco Costamagna <locutusofb...@debian.org> Checksums-Sha1: 7e31369ac4dce2d5baad3ab9074b7e0c7aeddf74 1685 verilator_4.016-3.dsc 653830b6c49a06ab65c729924797a2b53571e1b9 9892 verilator_4.016-3.debian.tar.xz 11ccbdaaa23ac17d00e39b98b93607cc05916255 5520 verilator_4.016-3_source.buildinfo Checksums-Sha256: 2c9d3ceded6a79cf7df6617f73e9c007fcd99f611f10f0858be87e0a535cdc5f 1685 verilator_4.016-3.dsc 52fe4499ff1931da846718f11c09a94095a6098fd628eb330f0149746db46dd6 9892 verilator_4.016-3.debian.tar.xz 2083bf4e3fdb3459099c721b88c396c7b884e813913d068bfd274b55c2f761c4 5520 verilator_4.016-3_source.buildinfo Files: 6606c027671df7086254af7c706a036c 1685 electronics optional verilator_4.016-3.dsc cc7351d42203f0870b92c498d690604e 9892 electronics optional verilator_4.016-3.debian.tar.xz 4f52a5f89155d9c263d788a2d637f247 5520 electronics optional verilator_4.016-3_source.buildinfo -----BEGIN PGP SIGNATURE----- iQEcBAEBCgAGBQJdIUK/AAoJELwZapTt3aG3o84H/3tpI1jwLTkHd2RG6qg5nI6z iIGy4nNiFrZp4RJYiMY8seq4gEpTKfQApRlRoS+wCHvnt2MaIXH2vN2SC33Vdqhs XJ6igvgERp9aCvnY641865R7pLRGa2jElgm3JtKAYG2tJIanJn1SazR2anqvWLAi GLr0+U+Sddf5f0syv+2YDKpeYTxfaWh7jlqw7ARhzu4w5FW7HKcqMBjGdWAiTL+L nMqOUuB0ZiepGN8N9sF1ZlEJ4szGles7nNEK+3xlGhanyshtAOpr642riyspEApN eFLmi144caZ8CFvudChJpQ4XBagSXCLUhvMAbDPLnXW8AgKYW7AQ1LlyPAMxMDg= =4YBn -----END PGP SIGNATURE-----
--- End Message ---
