Source: verilator
Version: 4.016-2
Severity: serious
Tags: patch experimental
Hello, looks like the new dwz from experimental makes verilator FTBFS, see:
https://bugs.launchpad.net/ubuntu/+source/dwz/+bug/1835398
reason is: debug flags are not injected to every package that is built, and the
new dwz in experimental
fails to compress them.
the attached patch fixes the build failure (that is showing only in
experimental, for now)
thanks for accepting, I sent it by email also upstream some minutes ago.
G.
Description: Honour system flags, this makes debug flags being injected correctly
Author: Gianfranco Costamagna <locutusofb...@debian.org>
Last-Update: 2019-07-06
--- verilator-4.016.orig/configure.ac
+++ verilator-4.016/configure.ac
@@ -91,10 +91,10 @@ AC_SUBST(CFG_WITH_PREC11)
AC_MSG_RESULT($CFG_WITH_PREC11)
# Compiler flags
-CFLAGS=-I${includedir}
-CPPFLAGS=-I${includedir}
-CXXFLAGS=-I${includedir}
-LDFLAGS=-L${libdir}
+CFLAGS+=" -I${includedir}"
+CPPFLAGS+=" -I${includedir}"
+CXXFLAGS+=" -I${includedir}"
+LDFLAGS+=" -L${libdir}"
# Checks for programs.
AC_PROG_CC
--- verilator-4.016.orig/src/Makefile_obj.in
+++ verilator-4.016/src/Makefile_obj.in
@@ -60,6 +60,8 @@ pkgdatadir = @pkgdatadir@
CFG_WITH_CCWARN = @CFG_WITH_CCWARN@
CFG_WITH_DEFENV = @CFG_WITH_DEFENV@
CPPFLAGS += @CPPFLAGS@
+CFLAGS += @CFLAGS@
+CXXFLAGS += @CXXFLAGS@
LDFLAGS += @LDFLAGS@
EXEEXT = @EXEEXT@
CFG_CXXFLAGS_SRC = @CFG_CXXFLAGS_SRC@
@@ -135,7 +137,7 @@ VLCOVGEN = $(srcdir)/vlcovgen
all: make_info $(TGT)
make_info:
- @echo " Compile flags: " $(CXX) ${CPPFLAGS}
+ @echo " Compile flags: " $(CXX) ${CFLAGS} ${CXXFLAGS} ${CPPFLAGS}
clean mostlyclean distclean maintainer-clean::
-rm -f *.o *.d perlxsi.c *_gen_*
@@ -280,21 +282,21 @@ V3Number_test: V3Number_test.o
$(PERL) $(ASTGEN) -I$(srcdir) $*.cpp
%.o: %.cpp
- $(OBJCACHE) ${CXX} ${CPPFLAGSWALL} -c $<
+ $(OBJCACHE) ${CXX} ${CXXFLAGS} ${CPPFLAGSWALL} -c $<
%.o: %.c
- $(OBJCACHE) ${CC} ${CPPFLAGSWALL} -c $<
+ $(OBJCACHE) ${CC} ${CFLAGS} ${CPPFLAGSWALL} -c $<
V3ParseLex.o: V3ParseLex.cpp V3Lexer.yy.cpp V3ParseBison.c
- $(OBJCACHE) ${CXX} ${CPPFLAGSPARSER} -c $<
+ $(OBJCACHE) ${CXX} ${CXXFLAGS} ${CPPFLAGSPARSER} -c $<
V3ParseGrammar.o: V3ParseGrammar.cpp V3ParseBison.c
- $(OBJCACHE) ${CXX} ${CPPFLAGSPARSER} -c $<
+ $(OBJCACHE) ${CXX} ${CXXFLAGS} ${CPPFLAGSPARSER} -c $<
V3ParseImp.o: V3ParseImp.cpp V3ParseBison.c
- $(OBJCACHE) ${CXX} ${CPPFLAGSPARSER} -c $<
+ $(OBJCACHE) ${CXX} ${CXXFLAGS} ${CPPFLAGSPARSER} -c $<
V3PreProc.o: V3PreProc.cpp V3PreLex.yy.cpp
- $(OBJCACHE) ${CXX} ${CPPFLAGSPARSER} -c $<
+ $(OBJCACHE) ${CXX} ${CXXFLAGS} ${CPPFLAGSPARSER} -c $<
#### Generated files
